chore(graph): use chi HTTP response wrapper instead of a homegrown one - #3517
Open
pbleser-oc wants to merge 1 commit into
Open
pbleser-oc wants to merge 1 commit into
pbleser-oc wants to merge 1 commit into
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Coverage variation | ✅ +0.00% coverage variation (-1.00%) |
| Diff coverage | ✅ 0.00% diff coverage |
Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (a6f8777) 88625 21132 23.84% Head commit (46d5f48) 88621 (-4) 21133 (+1) 23.85% (+0.00%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>
Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#3517) 3 0 0.00% Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
fschade
approved these changes
Sep 11, 2026
Member
|
@pbleser-oc Needs a rebase, because of the change minio image. |
pbleser-oc
force-pushed
the
chore/use-chi-request-wrapper-in-graph-metrics
branch
from
September 15, 2026 12:47
2c424db to
779da0e
Compare
* in the graph service's metrics, we use a homegrown response writer struct implementation to capture the status of the next handler's response: instead, use chi's implementation which is more sophisticated and battle tested
pbleser-oc
force-pushed
the
chore/use-chi-request-wrapper-in-graph-metrics
branch
from
September 15, 2026 12:48
779da0e to
46d5f48
Compare
pbleser-oc
changed the title
rhafer
approved these changes
Sep 15, 2026
rhafer
enabled auto-merge (rebase)
September 15, 2026 12:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the graph service's metrics, we use a homegrown response writer struct implementation to capture the status of the next handler's response: instead, use chi's implementation which is more sophisticated and battle tested.
How Has This Been Tested?
Has been tested by running the opencloud server with the changes and checking the resulting metrics.
Types of changes
Checklist: