fix(Dockerfile): run node-generate-prod from the repo root - #3175
Open
kost wants to merge 1 commit into
Open
Conversation
WORKDIR was set to /opencloud/opencloud before this RUN step, but node-generate-prod is only a real target in the repo-root Makefile (it fans out to every service's own node-generate-prod via $(MAKE) -C $$mod node-generate-prod). The nested opencloud/Makefile has no such target, so running from there does nothing -- silently, because it's mistaken for an already-satisfied file target rather than erroring -- and the resulting image ships without the web/idp frontend assets it was supposed to generate (services/idp/assets/ identifier/index.html in particular, which makes the idp service crash-loop with "Could not open index template").
Up to standards ✅🟢 Issues
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WORKDIR was set to /opencloud/opencloud before this RUN step, but node-generate-prod is only a real target in the repo-root Makefile (it fans out to every service's own node-generate-prod via$(MAKE) -C $ $mod node-generate-prod). The nested opencloud/Makefile has no such target, so running from there does nothing - silently, because it's mistaken for an already-satisfied file target rather than erroring - and the resulting image ships without the web/idp frontend assets it was supposed to generate (services/idp/assets/ identifier/index.html in particular, which makes the idp service crash-loop with "Could not open index template").
Types of changes