Skip to content

fix(search): use MustNot query for Deleted filter in bleve #3038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
flash7777 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(search): use MustNot query for Deleted filter in bleve #3038

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions services/search/pkg/bleve/backend.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,12 +51,18 @@ func (b *Backend) Search(_ context.Context, sir *searchService.SearchIndexReques
return nil, err
}

// Exclude documents that have been explicitly marked as deleted.
// We use a negation (MustNot) rather than matching Deleted==false,
// because bleve does not index zero-value bools, so documents where
// Deleted was never explicitly set would be excluded from results.
deletedQuery := bleve.NewBooleanQuery()
deletedQuery.AddMustNot(&query.BoolFieldQuery{
Bool: true,
FieldVal: "Deleted",
})

q := bleve.NewConjunctionQuery(
// Skip documents that have been marked as deleted
&query.BoolFieldQuery{
Bool: false,
FieldVal: "Deleted",
},
deletedQuery,
createdQuery,
)

Expand Down