fix(config): split domainKeyRe into separate domain and key regexes#54
Merged
fullstackjam merged 1 commit intomainfrom May 5, 2026
Merged
fix(config): split domainKeyRe into separate domain and key regexes#54fullstackjam merged 1 commit intomainfrom
fullstackjam merged 1 commit intomainfrom
Conversation
Spaces are valid in macOS preference keys (e.g. "NSStatusItem Visible Sound") but not in domains. The shared domainKeyRe introduced in #53 allowed spaces in both. Split into domainRe (no spaces) and keyRe (spaces allowed), and restore the domain-with-space test case that was inadvertently dropped.
|
👋 Thanks for opening this pull request! Before merging:
@fullstackjam will review this soon. Thanks for contributing! 🚀 |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
domainKeyReintodomainRe(no spaces) andkeyRe(spaces allowed)Context
#53 correctly allowed spaces in macOS preference keys (e.g.
NSStatusItem Visible Sound), but because the same regex was used for both domains and keys, spaces became valid in domains too (e.g.com.apple dock). This follow-up fixes the over-permissiveness without changing any user-facing behaviour.Test plan
go test -run TestValidateMacOSPrefs ./internal/config/...passesTestValidateMacOSPrefs_InvalidDomainCharactersnow uses a space in the domain (correctly rejected)TestValidateMacOSPrefs_KeyWithSpacesstill passes (spaces in keys still allowed)