fix(ui): repair tab-switch ghost text by bumping bubbletea 1.1 → 1.3#47
Merged
fullstackjam merged 2 commits intomainfrom Apr 22, 2026
Merged
fix(ui): repair tab-switch ghost text by bumping bubbletea 1.1 → 1.3#47fullstackjam merged 2 commits intomainfrom
fullstackjam merged 2 commits intomainfrom
Conversation
…st text
Root cause of the cirruslabs/cli ghost row on the macOS Prefs tab:
bubbletea v1.1.0 was written against x/ansi v0.2.3, but MVS resolved
x/ansi v0.4.2 via lipgloss v1.0.0. v0.4.2 silently broke two APIs that
v1.1.0's standard renderer depends on:
1. MoveCursor(row, col) → MoveCursor(col, row) — arguments swapped.
The post-flush "return cursor to last row" call landed the cursor
at row=1 instead of row=linesRendered, so the next render's
bottom-up EraseEntireLine/CursorUp1 loop could only clear row 1.
2. EraseEntireDisplay constant changed from "\x1b[2J" (clear visible)
to "\x1b[3J" (clear scrollback only). tea.ClearScreen therefore
left the alt-screen buffer untouched, making the PR #45 workaround
a no-op on the visible frame.
bubbletea v1.3.0 calls ansi.CursorPosition(col, row) and
ansi.EraseEntireScreen directly, matching the v0.4+ API. Tab switching
now clears and redraws correctly; the row-one-only erase artefact is
gone at its source.
|
👋 Thanks for opening this pull request! Before merging:
@fullstackjam will review this soon. Thanks for contributing! 🚀 |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
PR #45 forced a full repaint via tea.ClearScreen on Tab/Shift-Tab to mask a ghost-text bug whose actual root cause was bubbletea v1.1.0 silently miscalling x/ansi v0.4.2's MoveCursor and EraseEntireDisplay after MVS upgraded the latter via lipgloss. With bubbletea bumped to v1.3.0 in the previous commit, the renderer uses ansi.CursorPosition and ansi.EraseEntireScreen directly, so incremental diff rendering now clears rows correctly. The forced full repaint is therefore redundant (just extra flicker on every tab switch). Removing it.
fullstackjam
changed the title
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Root-cause fix for the tab-switch ghost-text bug that PR #45 worked around with
tea.ClearScreen. Also removes that now-redundant workaround.Why PR #45's workaround was incomplete
bubbletea
v1.1.0was written againstx/ansi v0.2.3, but Go MVS resolvedx/ansi v0.4.2vialipgloss v1.0.0. Two breaking changes inx/ansi v0.4.xsilently broke bubbletea'sstandard_renderer:MoveCursor(row, col)→MoveCursor(col, row)— arguments swapped. The post-flush "return cursor to last row" call landed the cursor atrow=1instead ofrow=linesRendered, so the next render's bottom-upEraseEntireLine/CursorUp1loop could only clear row 1 and left every row below untouched.EraseEntireDisplayconstant changed from\x1b[2J(clear visible screen) to\x1b[3J(clear scrollback only).tea.ClearScreentherefore left the alt-screen buffer untouched, making the PR Clear screen when switching tabs in snapshot editor #45tea.ClearScreenemit a no-op on the visible frame.That combination produced the one-row-offset ghost (
cirruslabs/clisticking above the macOS Prefs list after a Taps → Prefs tab switch).bubbletea
v1.3.0callsansi.CursorPosition(col, row)andansi.EraseEntireScreendirectly, matching the v0.4+ API. Incremental diff rendering now clears rows correctly, so the forced full repaint from #45 is redundant and removed.Changes
bubbletea: v1.1.0 → v1.3.0 (direct)x/ansi: v0.4.2 → v0.8.0 (indirect, via bubbletea)x/term: v0.2.0 → v0.2.1 (indirect)x/sync: v0.8.0 → v0.10.0 (indirect)internal/ui/snapshot_editor.go: drop thetea.ClearScreenworkaround on Tab / Shift-Tab.lipgloss/huh/bubblesare unchanged.Testing
go vet ./...go build ./...make test-unit(L1)./openboot snapshot→ tab through Formulae → Casks → NPM → Taps → macOS Prefs and back; confirm nocirruslabs/clighost at tab-switch and no flicker.Notes for reviewer
tea.ClearScreenwas load-bearing only because of the two ABI mismatches above; with v1.3.0 the renderer handles clearing itself, so removing it returns us to bubbletea's normal incremental-diff rendering (fewer full repaints, less flicker).huhso it doesn't rely on MVS goodwill for an ansi version compatible with its pinned v0.2.3.