Skip to content

Bugfix/154 colorstate comparison fails when comparing with null values#155

Merged
DivineThreepwood merged 44 commits intodevfrom
bugfix/154-colorstate-comparison-fails-when-comparing-with-null-values
Apr 14, 2026
Merged

Bugfix/154 colorstate comparison fails when comparing with null values#155
DivineThreepwood merged 44 commits intodevfrom
bugfix/154-colorstate-comparison-fails-when-comparing-with-null-values

Conversation

@DivineThreepwood
Copy link
Copy Markdown
Member

@DivineThreepwood DivineThreepwood commented Feb 18, 2026

📜 Description

Changes proposed in this pull request:

  • fix color state equals check
    • fix home assistant initial color lamp sync issue between hass and bco with it..
  • handle hue values 0 and 360 as equals
  • implement tests to prove implementation

✅ Checklist:

  • Created tests which fail without the change

@DivineThreepwood DivineThreepwood linked an issue Feb 18, 2026 that may be closed by this pull request
ColorState comparison fails when comparing with null values #154
Closed
@netlify
Copy link
Copy Markdown

netlify Bot commented Feb 18, 2026 •
edited
Loading

✅ Deploy Preview for basecubeone canceled.

Name Link
🔨 Latest commit 356119a
🔍 Latest deploy log https://app.netlify.com/projects/basecubeone/deploys/69deab1468f7df0008daf2fa

@DivineThreepwood DivineThreepwood added the preview Auto build a docker image and deploy it as a preview version. label Feb 18, 2026
lhuxohl
lhuxohl requested changes Feb 19, 2026
View reviewed changes
Comment thread ...src/main/java/org/openbase/bco/dal/lib/layer/service/provider/ColorStateProviderService.java Outdated
Comment thread ...src/main/java/org/openbase/bco/dal/lib/layer/service/provider/ColorStateProviderService.java Outdated
Comment thread ...c/test/java/org/openbase/bco/dal/lib/layer/service/provider/ColorStateProviderServiceTest.kt Outdated
Comment thread ...c/test/java/org/openbase/bco/dal/lib/layer/service/provider/ColorStateProviderServiceTest.kt
Comment thread ...c/test/java/org/openbase/bco/dal/lib/layer/service/provider/ColorStateProviderServiceTest.kt Outdated
Comment thread ...c/test/java/org/openbase/bco/dal/lib/layer/service/provider/ColorStateProviderServiceTest.kt
@lhuxohl lhuxohl removed their assignment Mar 10, 2026
@DivineThreepwood DivineThreepwood removed the preview Auto build a docker image and deploy it as a preview version. label Mar 10, 2026
lhuxohl
lhuxohl previously approved these changes Mar 10, 2026
View reviewed changes
@lhuxohl lhuxohl enabled auto-merge March 10, 2026 20:56
lhuxohl
lhuxohl previously approved these changes Mar 18, 2026
View reviewed changes
@DivineThreepwood DivineThreepwood linked an issue Apr 13, 2026 that may be closed by this pull request
Registry Deadlock during Location registration. #146
Closed
lhuxohl
lhuxohl previously approved these changes Apr 14, 2026
View reviewed changes
@DivineThreepwood DivineThreepwood merged commit 5e1da8e into dev Apr 14, 2026
15 of 17 checks passed
@DivineThreepwood DivineThreepwood deleted the bugfix/154-colorstate-comparison-fails-when-comparing-with-null-values branch April 14, 2026 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lhuxohl lhuxohl lhuxohl approved these changes

Assignees

No one assigned

Labels

test driven

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ColorState comparison fails when comparing with null values Registry Deadlock during Location registration.

2 participants

@DivineThreepwood @lhuxohl