fix(openapi-react-query): propagate undefined errors from empty-body non-OK responses#2822
Open
EduardF1 wants to merge 2 commits into
Open
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
👷 Deploy request for openapi-ts pending review.Visit the deploys page to approve it
|
🦋 Changeset detectedLatest commit: bdf4abf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Author
|
Thanks for the changeset reminder. This change should ship as a patch for |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Author
|
Added the missing changeset for \openapi-react-query\ and pushed it in bdf4abf. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2070.
What changed and why
queryFn,useInfiniteQuery'squeryFn, andmutationFnto throw whenerror !== undefined || !response.okresponseanywhere it was missing so the non-OK HTTP status is availableScenario fixed
When
openapi-fetchreturns{ data: undefined, error: undefined, response }for a non-OK response with an empty body (for example, a 4xx/5xx response withContent-Length: 0), the previousif (error)check treated the result as successful and swallowed the failure. This change propagates those undefined errors correctly by also checkingresponse.ok.