Skip to content

fix: handle null response.output in parse_response #3361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xlyoung wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

fix: handle null response.output in parse_response #3361

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/openai/lib/_parsing/_responses.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ def parse_response(
) -> ParsedResponse[TextFormatT]:
output_list: List[ParsedResponseOutputItem[TextFormatT]] = []

for output in response.output:
for output in (response.output or []):
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot Jun 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve streamed output when completed payload is null

When the streaming backend sends response.completed.response.output: null after already sending response.output_item.* and text/function deltas, this turns the completed response into output=[]. In ResponseStreamState.accumulate_event, the final response.completed event and get_final_response() are built from parse_response(event.response), not from the accumulated snapshot, so consumers no longer crash but silently lose all streamed output and parsed content in exactly the scenario this change is meant to handle. The null case should fall back to the accumulated snapshot/output rather than an empty list.

Useful? React with 👍 / 👎.

if output.type == "message":
content_list: List[ParsedContent[TextFormatT]] = []
for item in output.content:
Expand Down