test: exercise direct browser imports without credentials - #2501
Open
jbeckwith-oai wants to merge 1 commit into
Open
test: exercise direct browser imports without credentials#2501jbeckwith-oai wants to merge 1 commit into
jbeckwith-oai wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
Contributor
Castiron custom code✅ No new custom-code files detected. 32 mixed files remain; 0 existing customizations changed. Compared 32 existing customizations unchanged
A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 33044265342 --repo openai/openai-node \
--name castiron-custom-code-33044265342-1 --dir /tmp/castiron-custom-code-33044265342-1
git apply --stat /tmp/castiron-custom-code-33044265342-1/custom-code.patch
cat /tmp/castiron-custom-code-33044265342-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 76b73a9c73aafe11c60a425a82898705f1db966d dc39e9ab2d8bb98f080c3ad1e5921dd88899d8de
python3 scripts/castiron/custom_code_report.py report \
--base 76b73a9c73aafe11c60a425a82898705f1db966d \
--head dc39e9ab2d8bb98f080c3ad1e5921dd88899d8de --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-dc39e9ab2d8b
cat /tmp/castiron-custom-code-dc39e9ab2d8b/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes being requested
browser-direct-importPuppeteer fixture in ordinary credential-free ecosystem checks against the actual packed and installed SDK, using its existing native browser ESM import ofindex.mjswithout an import map.Verification
pnpm buildpnpm lintpnpm exec tsc --noEmitnpm run tscinecosystem-tests/browser-direct-import./scripts/test tests/ecosystem-cli.test.ts tests/ecosystem-browser-credential-security.test.ts(24 tests)main: fails immediately withFailed to resolve module specifier "#x509-transport-state"before any API request.Additional context & links
main, this new real-browser ecosystem regression intentionally exposes the existing failure; this PR does not include or stack on that production fix.