ci: gate npm publication on browser-compatible imports - #2500
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Castiron custom code✅ No new custom-code files detected. 32 mixed files remain; 0 existing customizations changed. Compared 32 existing customizations unchanged
A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 33044068289 --repo openai/openai-node \
--name castiron-custom-code-33044068289-1 --dir /tmp/castiron-custom-code-33044068289-1
git apply --stat /tmp/castiron-custom-code-33044068289-1/custom-code.patch
cat /tmp/castiron-custom-code-33044068289-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 76b73a9c73aafe11c60a425a82898705f1db966d 1c943049b797345c181fa8a227653436b9a2f06c
python3 scripts/castiron/custom_code_report.py report \
--base 76b73a9c73aafe11c60a425a82898705f1db966d \
--head 1c943049b797345c181fa8a227653436b9a2f06c --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-1c943049b797
cat /tmp/castiron-custom-code-1c943049b797/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
HAYDEN-OAI
left a comment
There was a problem hiding this comment.
Reviewed immutable protected-main release SHA validation across the compatibility and publication jobs, packed native-ESM graph resolution and package-root containment, fail-closed job ordering, pinned actions, read-only gate permissions, and exclusive OIDC access in the protected publish environment. Publication remains blocked until the verified release artifact passes browser import validation.
Summary
npm packthe exact verified release commit, then link the packed native-browser ESM graph and reject browser-unresolvable package specifiers or imports outside the artifactDependency and rollout
mainartifact correctly fails this guard on#x509-transport-state; merge fix: restore native browser ESM imports #2495 before activating this fail-closed publication gateVerification
pnpm buildpnpm lintpnpm exec tsc --noEmitnode --experimental-strip-types scripts/check-node-version-policy.ts#x509-transport-state) and a temporary repaired artifact (173 modules linked)