Skip to content

ci: require keyless ecosystem checks on release PRs - #2497

Merged
jbeckwith-oai merged 1 commit into
mainfrom
codex/require-keyless-ecosystem-ci
Aug 27, 2026
Merged

ci: require keyless ecosystem checks on release PRs#2497
jbeckwith-oai merged 1 commit into
mainfrom
codex/require-keyless-ecosystem-ci

Conversation

@jbeckwith-oai

Copy link
Copy Markdown
Contributor

Summary

  • Run the existing credential-free ecosystem/browser job on release-please branches as well as ordinary CI runs.
  • Include ecosystem checks in the existing required test_matrix aggregate, failing it when the ecosystem job fails, is cancelled, or is skipped.
  • Preserve read-only permissions, pinned actions, concurrent jobs, fork safety, and protected-main-only live API credentials.

This is an independently landable CI-only follow-up to #2494. The production browser-import fix is tracked separately in #2495 and is intentionally not included here.

Verification

  • ./scripts/test tests/ecosystem-cli.test.ts tests/ecosystem-browser-credential-security.test.ts (24 tests passed)
  • ./scripts/lint
  • Parsed the workflow and verified credential isolation, read-only permissions, pinned actions, release-branch execution, and required aggregate dependencies.
  • Executed the aggregate script with ecosystem results success, failure, cancelled, and skipped; only success passes.
  • Completed two consecutive clean adversarial-review rounds with two independent read-only reviewers per round.

@jbeckwith-oai
jbeckwith-oai requested a review from a team as a code owner August 27, 2026 05:52
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 27, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-27T05:53:32.967833Z 0f30e3b PR opened
🔒 Security Review Completed 2026-08-27T05:54:29.118789Z 0f30e3b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown
Contributor

Castiron custom code

✅ No new custom-code files detected.

32 mixed files remain; 0 existing customizations changed.

Compared 76b73a9c73aa0f30e3b2bcf7. Generated baselines verified.

32 existing customizations unchanged
  • api.md
  • scripts/castiron/README.md
  • scripts/castiron/custom_code_report.py
  • scripts/castiron/test_custom_code_report.py
  • src/client.ts
  • src/resources/audio/transcriptions.ts
  • src/resources/audio/translations.ts
  • src/resources/beta/assistants.ts
  • src/resources/beta/beta.ts
  • src/resources/beta/index.ts
  • src/resources/beta/responses/internal-base.ts
  • src/resources/beta/responses/responses.ts
  • src/resources/beta/threads/index.ts
  • src/resources/beta/threads/runs/index.ts
  • src/resources/beta/threads/runs/runs.ts
  • src/resources/beta/threads/threads.ts
  • src/resources/chat/completions/completions.ts
  • src/resources/chat/completions/index.ts
  • src/resources/conversations/index.ts
  • src/resources/embeddings.ts
  • src/resources/files.ts
  • src/resources/fine-tuning/checkpoints/permissions.ts
  • src/resources/images.ts
  • src/resources/responses/internal-base.ts
  • src/resources/responses/responses.ts
  • src/resources/skills/skills.ts
  • src/resources/skills/versions/versions.ts
  • src/resources/vector-stores/file-batches.ts
  • src/resources/vector-stores/files.ts
  • src/resources/webhooks/index.ts
  • src/resources/webhooks/webhooks.ts
  • tests/lib/data-residency.test.ts

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 33043916589 --repo openai/openai-node \
  --name castiron-custom-code-33043916589-1 --dir /tmp/castiron-custom-code-33043916589-1
git apply --stat /tmp/castiron-custom-code-33043916589-1/custom-code.patch
cat /tmp/castiron-custom-code-33043916589-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin 76b73a9c73aafe11c60a425a82898705f1db966d 0f30e3b2bcf76178cb1b43736bfa0b13b2628743
python3 scripts/castiron/custom_code_report.py report \
  --base 76b73a9c73aafe11c60a425a82898705f1db966d \
  --head 0f30e3b2bcf76178cb1b43736bfa0b13b2628743 --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-0f30e3b2bcf7
cat /tmp/castiron-custom-code-0f30e3b2bcf7/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch

@openai-sdks

openai-sdks Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

OkTest Summary

237/237 SDK tests passed in 9.82s for Node SDK PR #2497.

Test results — 42 files
Test Result Time
tests/chat-completions-complex-body.test.ts ✅ Passed 215ms
tests/chat-completions-create.test.ts ✅ Passed 204ms
tests/chat-completions-stream.test.ts ✅ Passed 168ms
tests/files-content-binary.test.ts ✅ Passed 144ms
tests/files-create-multipart.test.ts ✅ Passed 138ms
tests/files-list-pagination.test.ts ✅ Passed 130ms
tests/initialize-config.test.ts ✅ Passed 174ms
tests/instance-isolation.test.ts ✅ Passed 90ms
tests/models-list.test.ts ✅ Passed 129ms
tests/responses-background-lifecycle.test.ts ✅ Passed 210ms
tests/responses-body-method-errors.test.ts ✅ Passed 294ms
tests/responses-cancel-timeout.test.ts ✅ Passed 184ms
tests/responses-cancel.test.ts ✅ Passed 203ms
tests/responses-compact-retries.test.ts ✅ Passed 291ms
tests/responses-compact.test.ts ✅ Passed 180ms
tests/responses-create-advanced-stream.test.ts ✅ Passed 109ms
tests/responses-create-advanced.test.ts ✅ Passed 176ms
tests/responses-create-disconnect.test.ts ✅ Passed 1.115s
tests/responses-create-errors.test.ts ✅ Passed 182ms
tests/responses-create-malformed-api-responses.test.ts ✅ Passed 124ms
tests/responses-create-retries.test.ts ✅ Passed 274ms
tests/responses-create-stream-failures.test.ts ✅ Passed 205ms
tests/responses-create-stream-timeout.test.ts ✅ Passed 2.152s
tests/responses-create-stream-wire.test.ts ✅ Passed 2.356s
tests/responses-create-stream.test.ts ✅ Passed 107ms
tests/responses-create-terminal-states.test.ts ✅ Passed 232ms
tests/responses-create-timeout.test.ts ✅ Passed 198ms
tests/responses-create.test.ts ✅ Passed 132ms
tests/responses-delete.test.ts ✅ Passed 132ms
tests/responses-input-items-errors.test.ts ✅ Passed 168ms
tests/responses-input-items-list.test.ts ✅ Passed 167ms
tests/responses-input-items-options.test.ts ✅ Passed 104ms
tests/responses-input-tokens-count-timeout.test.ts ✅ Passed 215ms
tests/responses-input-tokens-count.test.ts ✅ Passed 275ms
tests/responses-malformed-inputs.test.ts ✅ Passed 2s
tests/responses-not-found-errors.test.ts ✅ Passed 224ms
tests/responses-parse.test.ts ✅ Passed 232ms
tests/responses-retrieve-retries.test.ts ✅ Passed 188ms
tests/responses-retrieve.test.ts ✅ Passed 250ms
tests/responses-stored-method-errors.test.ts ✅ Passed 502ms
tests/retry-behavior.test.ts ✅ Passed 3.039s
tests/sdk-error-shape.test.ts ✅ Passed 232ms

View OkTest run #33043899135

SDK merge (d9158508bdd2) · head (0f30e3b2bcf7) · base (76b73a9c73aa) · OkTest (2b1bdfd25e98)

@HAYDEN-OAI HAYDEN-OAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed release-branch execution, required aggregate dependency and failure semantics, fork-safe read-only permissions, pinned actions, and separation from protected live API credentials. The keyless ecosystem job now correctly participates in the required release and merge checks.

@jbeckwith-oai
jbeckwith-oai added this pull request to the merge queue Aug 27, 2026
Merged via the queue into main with commit b86efac Aug 27, 2026
35 checks passed
@jbeckwith-oai
jbeckwith-oai deleted the codex/require-keyless-ecosystem-ci branch August 27, 2026 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants