ci: require keyless ecosystem checks on release PRs - #2497
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Castiron custom code✅ No new custom-code files detected. 32 mixed files remain; 0 existing customizations changed. Compared 32 existing customizations unchanged
A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 33043916589 --repo openai/openai-node \
--name castiron-custom-code-33043916589-1 --dir /tmp/castiron-custom-code-33043916589-1
git apply --stat /tmp/castiron-custom-code-33043916589-1/custom-code.patch
cat /tmp/castiron-custom-code-33043916589-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 76b73a9c73aafe11c60a425a82898705f1db966d 0f30e3b2bcf76178cb1b43736bfa0b13b2628743
python3 scripts/castiron/custom_code_report.py report \
--base 76b73a9c73aafe11c60a425a82898705f1db966d \
--head 0f30e3b2bcf76178cb1b43736bfa0b13b2628743 --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-0f30e3b2bcf7
cat /tmp/castiron-custom-code-0f30e3b2bcf7/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
HAYDEN-OAI
left a comment
There was a problem hiding this comment.
Reviewed release-branch execution, required aggregate dependency and failure semantics, fork-safe read-only permissions, pinned actions, and separation from protected live API credentials. The keyless ecosystem job now correctly participates in the required release and merge checks.
Summary
test_matrixaggregate, failing it when the ecosystem job fails, is cancelled, or is skipped.This is an independently landable CI-only follow-up to #2494. The production browser-import fix is tracked separately in #2495 and is intentionally not included here.
Verification
./scripts/test tests/ecosystem-cli.test.ts tests/ecosystem-browser-credential-security.test.ts(24 tests passed)./scripts/lintsuccess,failure,cancelled, andskipped; onlysuccesspasses.