Skip to content

test: verify packed browser bundles target ES2020 - #2496

Open
jbeckwith-oai wants to merge 1 commit into
mainfrom
codex/packed-browser-es2020-bundle-2494
Open

test: verify packed browser bundles target ES2020#2496
jbeckwith-oai wants to merge 1 commit into
mainfrom
codex/packed-browser-es2020-bundle-2494

Conversation

@jbeckwith-oai

Copy link
Copy Markdown
Contributor

Summary

  • Extend the existing packed-package integration check to install the actual npm tarball and bundle an ordinary SDK import with Vite/Rolldown for browser-targeted ES2020 ESM.
  • Fail when package-internal imports cannot resolve, Node built-ins enter the browser graph, or the emitted bundle contains post-ES2020 syntax such as top-level await.
  • Reuse the existing Vitest/Vite and ts-node/Acorn dependency trees while keeping optional peers absent and leaving package metadata, lockfiles, webpack fixtures, CI policy, and production code unchanged.

Follow-up to #2494. Its native-browser production fix is handled independently in #2495; this PR is based directly on main and does not include or require that patch to pass.

Verification

  • PATH=/Users/jbeckwith/.nvm/versions/node/v24.16.0/bin:$PATH ./scripts/build
  • PATH=/Users/jbeckwith/.nvm/versions/node/v24.16.0/bin:$PATH node --experimental-strip-types scripts/test-packed-package.ts
  • node --experimental-strip-types scripts/test-packed-package.ts on Node 22.22.0
  • PATH=/Users/jbeckwith/.nvm/versions/node/v24.16.0/bin:$PATH ./scripts/lint
  • PATH=/Users/jbeckwith/.nvm/versions/node/v24.16.0/bin:$PATH node_modules/.bin/tsc
  • Injected unresolved #package imports, node:fs, and top-level await into the ignored built artifact and confirmed the packed-artifact check rejected all three.
  • Two consecutive adversarial review rounds with two independent read-only reviewers per round reported no in-scope findings.

@jbeckwith-oai
jbeckwith-oai requested a review from a team as a code owner August 27, 2026 05:52
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 27, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-27T05:53:42.395246Z 5d08b40 PR opened
🔒 Security Review Completed 2026-08-27T05:54:30.218620Z 5d08b40 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@openai-sdks

openai-sdks Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

OkTest Summary

237/237 SDK tests passed in 10.178s for Node SDK PR #2496.

Test results — 42 files
Test Result Time
tests/chat-completions-complex-body.test.ts ✅ Passed 139ms
tests/chat-completions-create.test.ts ✅ Passed 217ms
tests/chat-completions-stream.test.ts ✅ Passed 218ms
tests/files-content-binary.test.ts ✅ Passed 150ms
tests/files-create-multipart.test.ts ✅ Passed 140ms
tests/files-list-pagination.test.ts ✅ Passed 148ms
tests/initialize-config.test.ts ✅ Passed 140ms
tests/instance-isolation.test.ts ✅ Passed 101ms
tests/models-list.test.ts ✅ Passed 135ms
tests/responses-background-lifecycle.test.ts ✅ Passed 212ms
tests/responses-body-method-errors.test.ts ✅ Passed 316ms
tests/responses-cancel-timeout.test.ts ✅ Passed 204ms
tests/responses-cancel.test.ts ✅ Passed 237ms
tests/responses-compact-retries.test.ts ✅ Passed 204ms
tests/responses-compact.test.ts ✅ Passed 198ms
tests/responses-create-advanced-stream.test.ts ✅ Passed 131ms
tests/responses-create-advanced.test.ts ✅ Passed 160ms
tests/responses-create-disconnect.test.ts ✅ Passed 1.026s
tests/responses-create-errors.test.ts ✅ Passed 204ms
tests/responses-create-malformed-api-responses.test.ts ✅ Passed 172ms
tests/responses-create-retries.test.ts ✅ Passed 250ms
tests/responses-create-stream-failures.test.ts ✅ Passed 208ms
tests/responses-create-stream-timeout.test.ts ✅ Passed 2.174s
tests/responses-create-stream-wire.test.ts ✅ Passed 2.503s
tests/responses-create-stream.test.ts ✅ Passed 73ms
tests/responses-create-terminal-states.test.ts ✅ Passed 262ms
tests/responses-create-timeout.test.ts ✅ Passed 194ms
tests/responses-create.test.ts ✅ Passed 190ms
tests/responses-delete.test.ts ✅ Passed 192ms
tests/responses-input-items-errors.test.ts ✅ Passed 155ms
tests/responses-input-items-list.test.ts ✅ Passed 170ms
tests/responses-input-items-options.test.ts ✅ Passed 120ms
tests/responses-input-tokens-count-timeout.test.ts ✅ Passed 240ms
tests/responses-input-tokens-count.test.ts ✅ Passed 215ms
tests/responses-malformed-inputs.test.ts ✅ Passed 2.113s
tests/responses-not-found-errors.test.ts ✅ Passed 241ms
tests/responses-parse.test.ts ✅ Passed 180ms
tests/responses-retrieve-retries.test.ts ✅ Passed 292ms
tests/responses-retrieve.test.ts ✅ Passed 216ms
tests/responses-stored-method-errors.test.ts ✅ Passed 561ms
tests/retry-behavior.test.ts ✅ Passed 3.11s
tests/sdk-error-shape.test.ts ✅ Passed 282ms

View OkTest run #33043873971

SDK merge (144a4effd5bb) · head (5d08b4081812) · base (76b73a9c73aa) · OkTest (2b1bdfd25e98)

@github-actions

Copy link
Copy Markdown
Contributor

Castiron custom code

✅ No new custom-code files detected.

32 mixed files remain; 0 existing customizations changed.

Compared 76b73a9c73aa5d08b4081812. Generated baselines verified.

32 existing customizations unchanged
  • api.md
  • scripts/castiron/README.md
  • scripts/castiron/custom_code_report.py
  • scripts/castiron/test_custom_code_report.py
  • src/client.ts
  • src/resources/audio/transcriptions.ts
  • src/resources/audio/translations.ts
  • src/resources/beta/assistants.ts
  • src/resources/beta/beta.ts
  • src/resources/beta/index.ts
  • src/resources/beta/responses/internal-base.ts
  • src/resources/beta/responses/responses.ts
  • src/resources/beta/threads/index.ts
  • src/resources/beta/threads/runs/index.ts
  • src/resources/beta/threads/runs/runs.ts
  • src/resources/beta/threads/threads.ts
  • src/resources/chat/completions/completions.ts
  • src/resources/chat/completions/index.ts
  • src/resources/conversations/index.ts
  • src/resources/embeddings.ts
  • src/resources/files.ts
  • src/resources/fine-tuning/checkpoints/permissions.ts
  • src/resources/images.ts
  • src/resources/responses/internal-base.ts
  • src/resources/responses/responses.ts
  • src/resources/skills/skills.ts
  • src/resources/skills/versions/versions.ts
  • src/resources/vector-stores/file-batches.ts
  • src/resources/vector-stores/files.ts
  • src/resources/webhooks/index.ts
  • src/resources/webhooks/webhooks.ts
  • tests/lib/data-residency.test.ts

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 33043894758 --repo openai/openai-node \
  --name castiron-custom-code-33043894758-1 --dir /tmp/castiron-custom-code-33043894758-1
git apply --stat /tmp/castiron-custom-code-33043894758-1/custom-code.patch
cat /tmp/castiron-custom-code-33043894758-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin 76b73a9c73aafe11c60a425a82898705f1db966d 5d08b4081812b3e2078104f3d98cbd46dfe2611b
python3 scripts/castiron/custom_code_report.py report \
  --base 76b73a9c73aafe11c60a425a82898705f1db966d \
  --head 5d08b4081812b3e2078104f3d98cbd46dfe2611b --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-5d08b4081812
cat /tmp/castiron-custom-code-5d08b4081812/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant