test: verify packed browser bundles target ES2020 - #2496
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Castiron custom code✅ No new custom-code files detected. 32 mixed files remain; 0 existing customizations changed. Compared 32 existing customizations unchanged
A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 33043894758 --repo openai/openai-node \
--name castiron-custom-code-33043894758-1 --dir /tmp/castiron-custom-code-33043894758-1
git apply --stat /tmp/castiron-custom-code-33043894758-1/custom-code.patch
cat /tmp/castiron-custom-code-33043894758-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 76b73a9c73aafe11c60a425a82898705f1db966d 5d08b4081812b3e2078104f3d98cbd46dfe2611b
python3 scripts/castiron/custom_code_report.py report \
--base 76b73a9c73aafe11c60a425a82898705f1db966d \
--head 5d08b4081812b3e2078104f3d98cbd46dfe2611b --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-5d08b4081812
cat /tmp/castiron-custom-code-5d08b4081812/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
Summary
await.Follow-up to #2494. Its native-browser production fix is handled independently in #2495; this PR is based directly on
mainand does not include or require that patch to pass.Verification
PATH=/Users/jbeckwith/.nvm/versions/node/v24.16.0/bin:$PATH ./scripts/buildPATH=/Users/jbeckwith/.nvm/versions/node/v24.16.0/bin:$PATH node --experimental-strip-types scripts/test-packed-package.tsnode --experimental-strip-types scripts/test-packed-package.tson Node 22.22.0PATH=/Users/jbeckwith/.nvm/versions/node/v24.16.0/bin:$PATH ./scripts/lintPATH=/Users/jbeckwith/.nvm/versions/node/v24.16.0/bin:$PATH node_modules/.bin/tsc#packageimports,node:fs, and top-levelawaitinto the ignored built artifact and confirmed the packed-artifact check rejected all three.