fix: parse Google docstrings whose Args: follows a section body#3862
Merged
seratch merged 1 commit intoJul 17, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
griffe's Google parser skips a section header when there is no blank line above it and the next line is indented, which silently drops every parameter description. #3832 normalized that for a header sitting directly below the summary, but the helper only inserts the blank line when the preceding line is non-indented. An
Args:that follows another section's indented body still loses everything, and the tool reaches the model with no parameter descriptions:griffe applies that gate no matter how the preceding line is indented, so this drops the non-indented restriction and both cases normalize the same way. The header regex stays anchored at column 0, so an
Args:nested inside an example block still cannot match, and well-formed docstrings are still returned byte-identical.Test plan
Two tests: parameter descriptions survive when
Args:follows an indentedNote:body, and that variant produces the same schema as the well-formed version with the blank line. Both fail onmainand pass with the change..agents/skills/code-change-verification/scripts/run.shpasses (format, lint, typecheck, tests).Checks
.agents/skills/code-change-verification/scripts/run.sh/reviewbefore submitting this PR