-
Notifications
You must be signed in to change notification settings - Fork 4.2k
feat: add ResponseFormat support to call_model_input_filter (#3563) #3569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+42
−5
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
c9ef7dc
feat: add ResponseFormat support to call_model_input_filter (#3563)
ylzn567 29b8bb6
fix: resolve UnboundLocalError, fix typo, and pass None to filter
ylzn567 8f6f503
fix: pass current response_format to filter and forward it to model
ylzn567 17b8225
chore: remove response_format kwarg to prevent interface TypeError pe…
ylzn567 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a
call_model_input_filterreturns a modifiedModelInputData.response_format, the value is still discarded: this new argument only seeds the filter, while the subsequent model call continues to use the originaloutput_schemaand never readsfiltered.response_format(the streamed path does the same). Fresh evidence in this revision is that the earlier crash was removed, but the returned response format remains unused, so filters cannot actually enforce or disable a JSON schema despite the new API field.Useful? React with 👍 / 👎.