fix: #3348 propagate add_items structure metadata failure#3527
Open
kimnamu wants to merge 1 commit into
Open
Conversation
This was referenced May 29, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3348.
add_items()wraps_insert_structure_metadata()in atry/exceptthat rolls back, logs, and runs orphan cleanup — but then returns normally, so callers can't tell a partial failure from a success.This adds a single
raise RuntimeError(...) from eafter the existing cleanup block, so the failure surfaces to the caller while preserving the original exception viafrom e. The existing rollback, logging, and cleanup behaviour is untouched.Before / After
_insert_structure_metadata()raisesadd_items()returns normallyRuntimeErrorraised with original exception chained viafrom eTest
Adds
test_add_items_raises_on_structure_metadata_failure, which forces_insert_structure_metadatato raise, then assertsadd_items()raisesRuntimeErrorand that the orphaned message was still cleaned up.