fetch-pack: derive tunable worker defaults for URI packs - #75
Open
uoleg-oai wants to merge 1 commit into
Open
Conversation
Packfile URI fetches default to one job, and parallel URI indexers force one thread even when pack.threads is configured. Use online CPUs to choose defaults while retaining the existing configuration controls. Default fetch.packfileUriJobs to the online CPU count capped at eight. Divide CPUs among the actual parallel jobs for each indexer, with a one-thread minimum and four-thread automatic maximum. Explicit positive pack.threads overrides that budget; explicit URI job values remain uncapped and values at or below one retain serial processing. Preserve no-ref-delta negotiation and verification, serial fallback, pack ownership and cancellation. Document that increasing both controls can increase CPU and memory use. Verification: the new default-concurrency regression fails on the old implementation and passes with the change. The developer build and all 102 t5702 protocol tests pass, including real HTTP coverage, explicit thread values, job overrides and no-ref-delta validation. All 70 applicable t5300 index-pack tests pass; two !PTHREADS cases do not apply to this threaded build. Chainlint, greplint and documentation style checks pass. Independent review found no introduced P0/P1/P2 defects.
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packfile URI fetches default to one job, and parallel URI indexers force
one thread even when pack.threads is configured. Use online CPUs to
choose defaults while retaining the existing configuration controls.
Default fetch.packfileUriJobs to the online CPU count capped at eight.
Divide CPUs among the actual parallel jobs for each indexer, with a
one-thread minimum and four-thread automatic maximum. Explicit positive
pack.threads overrides that budget; explicit URI job values remain
uncapped and values at or below one retain serial processing.
Preserve no-ref-delta negotiation and verification, serial fallback,
pack ownership and cancellation. Document that increasing both controls
can increase CPU and memory use.
Verification: the new default-concurrency regression fails on the old
implementation and passes with the change. The developer build and all
102 t5702 protocol tests pass, including real HTTP coverage, explicit
thread values, job overrides and no-ref-delta validation. All 70
applicable t5300 index-pack tests pass; two !PTHREADS cases do not apply
to this threaded build. Chainlint, greplint and documentation style
checks pass. Independent review found no introduced P0/P1/P2 defects.
-- [ uoleg-codex (source thread) ]