[5/5] Move reasoning effort into step context#31737
Conversation
29e0fa2 to
c1b75f0
Compare
a44c1c4 to
98951f7
Compare
c1b75f0 to
fcc9c54
Compare
98951f7 to
e769b78
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
fcc9c54 to
8d52444
Compare
e769b78 to
c42baf6
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
8d52444 to
842106d
Compare
c42baf6 to
291ee93
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
291ee93 to
91dcea3
Compare
842106d to
9f8d7de
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Migrated to https://github.com/openai/codex-internal/pull/1673 following the codex-internal cutover. Please continue review there; this public PR is superseded. |
Why
Reasoning effort is consumed by request-scoped work, but it is currently stored on the longer-lived
TurnContext. With the captured step now propagated through sampling, compaction, guardian, and execution paths, the value can travel with the request snapshot that uses it.What changed
reasoning_effortand the effective-effort helpers fromTurnContexttoStepContext.Stacked on #31736. This is PR 5 of 5 and intentionally does not normalize raw effort to effective effort.
Validation
cargo check -p codex-core --tests --message-format short