expose dynamic tool namespace descriptions#24691
Open
sayan-oai wants to merge 2 commits into
Open
Conversation
sayan-oai
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7041a830d1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
sayan-oai
commented
May 27, 2026
| LoadableToolSpec::Function(tool) | ||
| } | ||
| ToolSpec::Namespace(mut namespace) => { | ||
| if namespace.description.trim().is_empty() { |
Collaborator
Author
There was a problem hiding this comment.
keep empty descriptions until matching namespace results are merged, so later populated descriptions aren't hidden by an earlier default. If none is supplied, apply the default after merging.
this also fixes the same issue for deferred MCP tools.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Dynamic tools can be grouped into a Responses namespace, but app-server clients currently cannot supply namespace-level context for that group. For deferred dynamic tools,
tool_searchtherefore exposes only a generated namespace description, losing information that helps the model understand when revealed tools are appropriate.When multiple tools share a namespace, a supplied description must also win over the generated fallback regardless of tool order; otherwise an earlier undescribed tool can mask the newly supplied metadata.
Context: internal discussion
What
namespaceDescriptionsupport to the app-server v2DynamicToolSpecAPI and generated schemas, and propagate it into core dynamic tool specs and persisted thread state.tool_searchdiscovery metadata.tool_searchintegration coverage.Verification
just test -p codex-app-server-protocolcodex-core/codex-toolstests covering dynamic namespace planning, code-mode fallback behavior, and TST reveal/call routing.codexfrom source and ran a live app-server session with a deferred namespaced dynamic tool;tool_searchrevealed it with the supplied namespace description, the namespaced tool call completed, and the assistant returned its marker result.