Skip to content

Add app-server startup benchmark crate#24651

Merged
anp-oai merged 7 commits into
mainfrom
codex/app-server-start
May 28, 2026
Merged

Add app-server startup benchmark crate#24651
anp-oai merged 7 commits into
mainfrom
codex/app-server-start

Conversation

@anp-oai
Copy link
Copy Markdown
Collaborator

@anp-oai anp-oai commented May 26, 2026

Summary

  • Add a new app-server-start-bench crate to measure app-server startup performance
  • Wire the benchmark into the workspace and Bazel build so it can be run consistently
  • Update lockfiles and repo automation to account for the new package

@anp-oai anp-oai force-pushed the codex/app-server-start branch 2 times, most recently from d36982f to 630b6df Compare May 27, 2026 15:35
@anp-oai anp-oai marked this pull request as ready for review May 27, 2026 15:36
Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 630b6df00d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/benchmarks/app-server-start/BUILD.bazel
Comment thread justfile Outdated
Comment thread codex-rs/Cargo.toml
@anp-oai
Copy link
Copy Markdown
Collaborator Author

anp-oai commented May 27, 2026

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown
Contributor

Codex Review: Didn't find any major issues. Swish!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@anp-oai anp-oai force-pushed the codex/app-server-start branch 2 times, most recently from 800d70d to 31bc341 Compare May 27, 2026 22:33
@anp-oai anp-oai force-pushed the codex/app-server-start branch from 31bc341 to 04ae848 Compare May 28, 2026 00:23
@anp-oai
Copy link
Copy Markdown
Collaborator Author

anp-oai commented May 28, 2026

@codex review

Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 04ae8484b2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread justfile
Comment thread .github/workflows/rust-ci-full.yml
Copy link
Copy Markdown
Collaborator

@bolinfest bolinfest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, let's give it a shot!

Comment on lines +72 to +73
.arg("--listen")
.arg("stdio://")
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was really hoping we would replace this with --stdio, but I guess that hasn't happened...

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR inbound :)

@anp-oai anp-oai merged commit bd2a732 into main May 28, 2026
46 checks passed
@anp-oai anp-oai deleted the codex/app-server-start branch May 28, 2026 15:46
@github-actions github-actions Bot locked and limited conversation to collaborators May 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants