Skip to content

fix(ci): use supported release workflow concurrency - #324

Open
mldangelo-oai wants to merge 1 commit into
mainfrom
mdangelo/codex/fix-release-workflow-concurrency-20260808
Open

fix(ci): use supported release workflow concurrency#324
mldangelo-oai wants to merge 1 commit into
mainfrom
mdangelo/codex/fix-release-workflow-concurrency-20260808

Conversation

@mldangelo-oai

Copy link
Copy Markdown
Collaborator

Summary

  • Replace unsupported concurrency.queue with GitHub-supported cancel-in-progress: false in release cutting, protected npm publishing, and GitHub release publication.
  • Add focused regression coverage that rejects unsupported workflow concurrency keys.
  • Keep the protected npm release workflow synchronized with openai/openai#1262925.

Verification

  • bun test --timeout 30000 tests-ts/release-automation.test.ts tests-ts/release-cut-workflow.test.ts tests-ts/skeleton.test.ts (201 passing)
  • tsc --noEmit --incremental false
  • Prettier checks on all four changed files
  • YAML structural validation of all three workflow concurrency blocks

@github-actions github-actions Bot added the bug Something isn't working label Aug 8, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 83848e1eec

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

concurrency:
group: node-release-cut
queue: max
cancel-in-progress: false

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve every pending release run

When one run is active and two more releases enter the same concurrency group, cancel-in-progress: false protects only the active run: GitHub documents that there can be “at most one running and one pending job” and that a new queued run replaces the existing pending run. Consequently, the analogous changes in node-release-cut.yml, node-release.yml, and node-github-release.yml can discard an intermediate version/tag or backfill during overlapping releases, despite the tests claiming every release is serialized; these workflows need a durable dispatch/queue mechanism rather than treating cancel-in-progress: false as equivalent to queue: max.

Useful? React with 👍 / 👎.

@chatgpt-codex-connector

Copy link
Copy Markdown

Security review completed. No security issues were found in this pull request.

Reviewed commit: 83848e1eec

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant