Skip to content

make pnp ip configurable#3584

Merged
benderl merged 2 commits into
openWB:masterfrom
benderl:feature-pnp-ip
Jun 23, 2026
Merged

make pnp ip configurable#3584
benderl merged 2 commits into
openWB:masterfrom
benderl:feature-pnp-ip

Conversation

@benderl

@benderl benderl commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

@benderl benderl added this to the 2.3.0 milestone Jun 23, 2026
@benderl benderl self-assigned this Jun 23, 2026
@benderl benderl added enhancement New feature or request ui depends on changes in ui repository labels Jun 23, 2026
@benderl benderl force-pushed the feature-pnp-ip branch 2 times, most recently from 13a5583 to c36a557 Compare June 23, 2026 07:38
@benderl benderl requested a review from Copilot June 23, 2026 07:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Implements a configurable Plug’n’Play (PnP) virtual IP address (instead of a hard-coded 192.168.193.250/24) by introducing a new persisted MQTT config topic and wiring it through network setup, config defaults, validation, and ACLs.

Changes:

  • Add new system config topic openWB/system/pnp_ip (with default {address, prefix}) and allow it in config update defaults/validation.
  • Update runs/setup_network.sh to read and validate pnp_ip from MQTT and apply it via ip addr add/del.
  • Extend Mosquitto dynamic-security ACL templates to allow publishing/receiving the new topic and bump ACL template version.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
runs/setup_network.sh Reads openWB/system/pnp_ip from MQTT, validates it, and configures the PnP IP on the primary interface.
packages/helpermodules/update_config.py Adds openWB/system/pnp_ip (and mac_address) to allowed topics and publishes default values.
packages/helpermodules/subdata.py Detects pnp_ip changes and notifies users that a restart is required.
packages/helpermodules/setdata.py Allows setting openWB/set/system/pnp_ip with JSON payload validation.
data/config/mosquitto/public/default-dynamic-security.json Adds ACLs for the new topic and bumps the template ACL version marker.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread runs/setup_network.sh
Comment thread runs/setup_network.sh Outdated
Comment thread packages/helpermodules/subdata.py
Comment thread packages/helpermodules/setdata.py Outdated
@benderl benderl requested a review from LKuemmel June 23, 2026 08:17
@benderl benderl merged commit 132ff1d into openWB:master Jun 23, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request ui depends on changes in ui repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make PnP IP Address configurable

3 participants