make pnp ip configurable#3584
Merged
Merged
Conversation
13a5583 to
c36a557
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Implements a configurable Plug’n’Play (PnP) virtual IP address (instead of a hard-coded 192.168.193.250/24) by introducing a new persisted MQTT config topic and wiring it through network setup, config defaults, validation, and ACLs.
Changes:
- Add new system config topic
openWB/system/pnp_ip(with default{address, prefix}) and allow it in config update defaults/validation. - Update
runs/setup_network.shto read and validatepnp_ipfrom MQTT and apply it viaip addr add/del. - Extend Mosquitto dynamic-security ACL templates to allow publishing/receiving the new topic and bump ACL template version.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
runs/setup_network.sh |
Reads openWB/system/pnp_ip from MQTT, validates it, and configures the PnP IP on the primary interface. |
packages/helpermodules/update_config.py |
Adds openWB/system/pnp_ip (and mac_address) to allowed topics and publishes default values. |
packages/helpermodules/subdata.py |
Detects pnp_ip changes and notifies users that a restart is required. |
packages/helpermodules/setdata.py |
Allows setting openWB/set/system/pnp_ip with JSON payload validation. |
data/config/mosquitto/public/default-dynamic-security.json |
Adds ACLs for the new topic and bumps the template ACL version marker. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
LKuemmel
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ui: openWB/openwb-ui-settings#997
closes https://github.com/openWB/internal-projects/issues/175
closes #3365