Improvements for the opcua generic client#23
Improvements for the opcua generic client#23viacheslauK wants to merge 15 commits intogeneric-clientfrom
Conversation
viacheslauK
force-pushed
the
improvements-for-generic-client
branch
from
d29b0d7 to
b8e044e
Compare
viacheslauK
requested review from
JakaMohorko,
NikolaiShipilov and
denise-opendaq
…ericClientDeviceImpl class
…node; improving a device localID forming
viacheslauK
force-pushed
the
improvements-for-generic-client
branch
from
b8e044e to
8d029fc
Compare
denise-opendaq
left a comment
denise-opendaq
left a comment
There was a problem hiding this comment.
Overall looks good, but there are some notes and questions
- the device and fb implementation should be inside the module folder
- there is no way to browse available nodes, so I should use another program to get node id and then pass it it fb. can we fixed it ?
- hard to define which ouput signal of fbs reflects the server signal (all the time should check the fb prop)
- do we need to change the connected signal dynamcly in fb (maybe its easier to create fb with property of signal node id. Then fb will create the signal with meaningful id. And after the only setting will be in use is sample rate ?)
|
|
||
| configConnectionInfo.setProtocolId(DaqOpcUaGenericProtocolId) | ||
| .setProtocolName(DaqOpcUaGenericProtocolName) | ||
| .setProtocolType(ProtocolType::Unknown) |
There was a problem hiding this comment.
probably ProtocolType::Streaming
There was a problem hiding this comment.
This protocol is not streaming one. It does not meet the requirements that the openDAQ imposes on a streaming protocol.
| defaultConfig.addProperty(StringProperty(PROPERTY_NAME_OPCUA_MI_LOCAL_ID, "")); | ||
|
|
||
| { | ||
| auto builder = SelectionPropertyBuilder(PROPERTY_NAME_OPCUA_TS_MODE, |
There was a problem hiding this comment.
this property is used only for the function blocks. why can we move this property to the fb itself?
also what is the difference between ServerTimestamp and SourceTimestamp
There was a problem hiding this comment.
Because in this case a user have to set this property for all nested FB (if he wants to have different timestamp source). For example, if there are 100 FBs, a user have to set 100 properties. Now he needs to set it only once.
There was a problem hiding this comment.
ServerTimestamp and SourceTimestamp are OPCUA terms. See https://reference.opcfoundation.org/Core/Part4/v104/docs/7.7.3 and http://reference.opcfoundation.org/Core/Part4/v104/docs/7.7.4
…an error message (if present)
3 participants
TimestampModeproperty is moved to theOpcuaGenericClientDeviceImplclass;DeviceNodeIDproperties to read metadata for fillingDeviceInfo;