-
Notifications
You must be signed in to change notification settings - Fork 899
feat(logs): add OTEL_LOG_LEVEL support #5115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
grvmishra788
wants to merge
19
commits into
open-telemetry:main
Choose a base branch
from
grvmishra788:worktree-issue-1059
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+132
−2
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
b36d053
feat(logs): add OTEL_LOG_LEVEL support
grvmishra788 7c01660
update CHANGELOG
grvmishra788 52e069c
Merge branch 'main' into worktree-issue-1059
grvmishra788 100a78c
Merge branch 'main' into worktree-issue-1059
grvmishra788 93fcffd
improve log level handling
grvmishra788 5283977
add OTEL SDK init
grvmishra788 8fc84d1
Merge branch 'main' into worktree-issue-1059
grvmishra788 a8cf853
update changelog
grvmishra788 ff00ae5
Merge branch 'main' into worktree-issue-1059
grvmishra788 ebe9bc6
Merge branch 'main' into worktree-issue-1059
grvmishra788 501df97
Merge branch 'main' into worktree-issue-1059
MikeGoldsmith 3bf9f5d
Merge branch 'main' into worktree-issue-1059
MikeGoldsmith 885b2d0
Merge branch 'main' into worktree-issue-1059
grvmishra788 9ddee27
Merge branch 'main' into worktree-issue-1059
grvmishra788 e99f1bc
move _configure_otel_log_level
grvmishra788 a085c41
chore: update changelog for SDK
grvmishra788 ad9bd3a
Merge branch 'main' into worktree-issue-1059
grvmishra788 06a7a12
Merge branch 'main' into worktree-issue-1059
grvmishra788 8acdaea
fix(logs): map OTEL_LOG_LEVEL=trace to DEBUG
grvmishra788 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| `opentelemetry-sdk`: honour `OTEL_LOG_LEVEL` to set SDK internal log level |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this should also map
tracetodebug. The OTEL_LOG_LEVEL spec doesn't define accepted values, but the declarative config schema includes trace. Since Python doesn't have trace, mapping trace to debug would align with the config model and with the debug startup messages PR that Tammy mentioned.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call - done. "trace" now maps to DEBUG. Updated the dict, the warning message listing valid values, and the tests.