Fix: test_install_shim_affects_existing_tracers assumes wrong default tracer type#5047
Open
sakshar2303 wants to merge 2 commits intoopen-telemetry:mainfrom
Open
Fix: test_install_shim_affects_existing_tracers assumes wrong default tracer type#5047sakshar2303 wants to merge 2 commits intoopen-telemetry:mainfrom
sakshar2303 wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
MikeGoldsmith
approved these changes
Apr 13, 2026
Member
There was a problem hiding this comment.
Looks good - thanks @sakshar2303. I've left one minor suggestion.
You'll need to a changelog entry too please.
Comment on lines
+45
to
+46
| original_tracer = oc_tracer.tracer | ||
| self.assertNotIsInstance(original_tracer, ShimTracer) |
Member
There was a problem hiding this comment.
Could we do this instead of creating a tracer instance?
Suggested change
| original_tracer = oc_tracer.tracer | |
| self.assertNotIsInstance(original_tracer, ShimTracer) | |
| self.assertNotIsInstance(oc_tracer.tracer, ShimTracer) |
MikeGoldsmith
added
Skip Changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test was incorrectly assuming that Tracer() creates a NoopTracer,
but OpenCensus 0.11.1 creates a ContextTracer by default.
Updated the test to:
All tests pass.