Don't call set attribute twice for the same key and make start attributes unsettable

[lmolkova]

No description provided.

[Copilot]

Pull request overview

This PR refactors GenAI invocation types to (1) only set sampling-relevant attributes at span start (avoiding re-setting the same attribute keys again at finish) and (2) encourage providing span-name/sampling inputs at invocation construction time (e.g., passing agent_name into invoke_local_agent(...)).

Changes:

• Split “start-time” vs “finish-time” attribute setting by introducing _get_start_attributes() and removing duplicated set_attributes(...) keys at finish.
• Make several start-time fields “construction-time only” (e.g., agent name/model/server info) and update tests to pass them at construction.
• Update OpenAI response streaming wrapper to populate response_model_name instead of mutating request_model.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 14 comments.

Show a summary per file

File	Description
util/opentelemetry-util-genai/src/opentelemetry/util/genai/_workflow_invocation.py	Uses start-only attributes and stores workflow name internally (_name).
util/opentelemetry-util-genai/src/opentelemetry/util/genai/_tool_invocation.py	Moves tool metadata to start-time attributes and avoids re-setting at finish.
util/opentelemetry-util-genai/src/opentelemetry/util/genai/_retrieval_invocation.py	Moves retrieval sampling attributes to start-time, avoids duplication at finish.
util/opentelemetry-util-genai/src/opentelemetry/util/genai/_inference_invocation.py	Renames “start attributes” helper and removes syncing deprecated container fields that are now start-only.
util/opentelemetry-util-genai/src/opentelemetry/util/genai/_embedding_invocation.py	Restricts provider/model/server fields to start-time attributes; finish sets only non-start fields.
util/opentelemetry-util-genai/src/opentelemetry/util/genai/_agent_invocation.py	Moves sampling-relevant agent fields to start-time; updates finish-time attribute grouping.
util/opentelemetry-util-genai/tests/test_workflow_invocation.py	Updates workflow invocation tests for the new name storage/behavior.
util/opentelemetry-util-genai/tests/test_handler_workflow.py	Updates workflow handler tests for the new name storage/behavior.
util/opentelemetry-util-genai/tests/test_handler_retrieval.py	Updates retrieval handler tests for the new data source id storage/behavior.
util/opentelemetry-util-genai/tests/test_handler_completion_hook.py	Updates completion-hook test to pass agent_name at construction.
util/opentelemetry-util-genai/tests/test_handler_agent.py	Updates agent tests to pass agent_name at construction and reflect start-only fields.
util/opentelemetry-util-genai/.changelog/150.changed	Adds a towncrier fragment describing the behavioral change.
instrumentation/opentelemetry-instrumentation-genai-openai/tests/test_embedding_invocation_unit.py	Drops assertions tied to mutable request_model state.
instrumentation/opentelemetry-instrumentation-genai-openai/src/opentelemetry/instrumentation/genai/openai/response_wrappers.py	Sets response_model_name (actual model) instead of mutating request_model.

[opentelemetry-pr-dashboard]

Pull request dashboard status

Status: Waiting on maintainers to merge the pull request.