opentelemetry-instrumentation-aiopg: fix manual connection attributes#4821
Open
henry3260 wants to merge 2 commits into
Open
opentelemetry-instrumentation-aiopg: fix manual connection attributes#4821henry3260 wants to merge 2 commits into
henry3260 wants to merge 2 commits into
Conversation
10 tasks
henry3260
force-pushed
the
aiopg-manual-connection-attributes
branch
from
July 16, 2026 03:51
467d180 to
f011407
Compare
henry3260
force-pushed
the
aiopg-manual-connection-attributes
branch
from
July 16, 2026 03:56
f011407 to
4e45147
Compare
xrmx
requested changes
Jul 16, 2026
github-project-automation
Bot
moved this from Ready for review
to Reviewed PRs that need fixes
in Python PR digest
Contributor
Author
Sure :) |
henry3260
force-pushed
the
aiopg-manual-connection-attributes
branch
from
July 16, 2026 08:54
4e45147 to
8a050ba
Compare
henry3260
force-pushed
the
aiopg-manual-connection-attributes
branch
from
July 16, 2026 09:14
8a050ba to
58da5f5
Compare
emdneto
approved these changes
Jul 16, 2026
emdneto
moved this from Reviewed PRs that need fixes
to Ready for merge
in Python PR digest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix aiopg manual instrumentation to read database connection attributes from the underlying psycopg2 connection. Also simplify operation-name resolution by delegating empty arguments to the shared DBAPI helper. No additional dependencies are required.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
uvx tox -e py310-test-instrumentation-aiopg-wrapt2uvx tox -e py312-test-instrumentation-aiopg-wrapt2Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.