test(aiohttp-server): make non-global tracer provider test deterministic#4815
Open
DebadityaHait wants to merge 1 commit into
Open
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make
test_non_global_tracer_providerdeterministic by using the always-on sampler and a single request. The test now verifies that exactly one server span is exported through the supplied provider and checks its expected name, kind, method, status, and target.This removes the statistical sampling bounds without weakening coverage of the non-global provider path.
Fixes #4811
Type of change
How Has This Been Tested?
Does This PR Require a Core Repo Change?
Checklist