feat: Update kafka python instrumentation to support kafka-python>=3#4786
feat: Update kafka python instrumentation to support kafka-python>=3#4786rjduffner wants to merge 1 commit into
Conversation
| @@ -0,0 +1,14 @@ | |||
| kafka-python>=3.0.0,<4.0.0 | |||
There was a problem hiding this comment.
Also here, I'd prefer we keep this pinned. You can also look at
uv pip compile.
|
The rage committing 🤣 |
|
haha, ya. A mentor when i was very junior always made me commit often. However, since we squashed commits, the messages never had to be good. Well the habit stuck. whoops. |
|
@herin049, thanks for the comment. I actually like that earliest latest pattern instead of the 0,1,2 I stole from another instrumentation. I have some questions though and forgive me, I haven't contributed in a while and it was before the switch to uv. I am trying to figure out how to use So is your workflow something like this to create the "low" requirements?
Or am I missing something? Apologies if i missed something simple. |
We typically use Quoting from the uv docs:
You can see an example of the exact command used here: |
afe2226 to
430e048
Compare
430e048 to
9d84b30
Compare
|
Yup it was something simple. Totally missed the comment in the generated file. Thank you and sorry about that. Changes made. |
emdneto
left a comment
There was a problem hiding this comment.
Not related to this PR, but I think we can drop support for kafka-python-ng now kafka-python development is active again. @rjduffner
|
@emdneto, I agree. My original PR had the drop of kafka-python-ng in it but I pulled it out as it would technically be a breaking change and I wasn't sure if we wanted to do that. I can follow up with ripping that out in a second pr if desired. |
Sure. Created an issue about that. |
Description
While kafka-python version 3.0.0 is actually a pretty large change, https://github.com/dpkp/kafka-python/releases/tag/3.0.0, the breaking changes don't seem to be exercised by the instrumentation.
I updated the instrumentation to include support for versions > 3 but also kept testing older versions as well.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Make sure the current tests pass with the new library versions.
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.