-
Notifications
You must be signed in to change notification settings - Fork 960
[opentelemetry-instrumentation-grpc] Add support for metrics #4621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lorenzoronzani
wants to merge
13
commits into
open-telemetry:main
Choose a base branch
from
lorenzoronzani:feature/add-metrics-to-grpc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
96852c2
Implementing first version of metrics for gRPC server
lorenzoronzani f1c46a0
created a constant
lorenzoronzani 543acb5
Implemented metrics into client
lorenzoronzani e8a48c9
Added aio clients and servers
lorenzoronzani 53e4b08
Edited client
lorenzoronzani 55dd9c0
Removed None
lorenzoronzani cf6e4b3
Added changelog edit
lorenzoronzani d25bf7d
Merge branch 'main' into feature/add-metrics-to-grpc
emdneto 3ea4785
Merge branch 'main' into feature/add-metrics-to-grpc
lorenzoronzani 519fec7
Integrated first 3 comments
lorenzoronzani 2702b3f
ruff
lorenzoronzani 48a90e2
Integrated comments
lorenzoronzani 5219282
Integrated comments
lorenzoronzani File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| `opentelemetry-instrumentation-grpc`: add rpc.client.call.duration and rpc.server.call.duration metrics for both sync and async components |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.