feat: support COMPATIBLE_TLS connectionSpec in OkHttpHttpSender#8594
Draft
singhlovepreet9 wants to merge 3 commits into
Draft
feat: support COMPATIBLE_TLS connectionSpec in OkHttpHttpSender#8594singhlovepreet9 wants to merge 3 commits into
singhlovepreet9 wants to merge 3 commits into
Conversation
|
Member
|
Hey I gave this issue some thought and shared my analysis here: #7573 (comment) I think we should go in a different direction with this: #8610, which embodies option d in the comment. |
Pull request dashboard status
|
singhlovepreet9
force-pushed
the
feat/okhttp-compatible-tls
branch
from
July 18, 2026 13:59
253ebda to
1439a69
Compare
Contributor
|
singhlovepreet9
marked this pull request as draft
July 18, 2026 14:06
singhlovepreet9
force-pushed
the
feat/okhttp-compatible-tls
branch
from
July 18, 2026 15:35
1439a69 to
515d117
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #8594 +/- ##
=========================================
Coverage 91.64% 91.64%
- Complexity 10348 10372 +24
=========================================
Files 1013 1013
Lines 27380 27441 +61
Branches 3218 3230 +12
=========================================
+ Hits 25092 25149 +57
- Misses 1558 1559 +1
- Partials 730 733 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7573.
This PR adds
ConnectionSpec.COMPATIBLE_TLSto theOkHttpClient.Builder'sconnectionSpecsfor HTTPS endpoints, enabling support for legacy systems like WebSphere 8.x / IBM J9 Java 1.8 that cannot satisfy the requirements ofMODERN_TLS.By configuring
OkHttpHttpSenderto fall back toCOMPATIBLE_TLSwhenMODERN_TLSis unavailable, we maintain the highest possible level of security while unblocking telemetry exports on older JVMs.