Skip to content

feat: support general attribute limits - #4480

Open
NAND-369 wants to merge 1 commit into
open-telemetry:mainfrom
NAND-369:fix/general-attribute-limits
Open

feat: support general attribute limits#4480
NAND-369 wants to merge 1 commit into
open-telemetry:mainfrom
NAND-369:fix/general-attribute-limits

Conversation

@NAND-369

Copy link
Copy Markdown

Changes

Adds support for configuring general attribute_limits and propagating them to tracer and logger providers.

Implementation

  • Added general attribute limit propagation to TracerProvider and LoggerProvider.
  • Added provider-specific override support.
  • Added partial override handling for attribute count and value length limits.
  • Preserved existing provider-specific limits and defaults.
  • Updated YAML parsing to distinguish configured values from omitted/null values.

Tests

Added coverage for:

  • General attribute limits
  • Provider-specific overrides
  • Partial count overrides
  • Partial value-length overrides
  • YAML partial configurations
  • YAML null values
  • Programmatic tracer/logger configuration

Verification

  • git diff --check passes
  • Build succeeds
  • Targeted configuration tests: 75/75 passed
  • Full test suite: 986/986 passed

@NAND-369
NAND-369 requested a review from a team as a code owner August 26, 2026 01:03
@linux-foundation-easycla

linux-foundation-easycla Bot commented Aug 26, 2026

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: NAND-369 / name: Nandan (d6341b4)

@dbarker

dbarker commented Aug 26, 2026

Copy link
Copy Markdown
Member

Hi @NAND-369, Thanks for the contribution! There is already a PR (#4468) open to address #4467 and this PR is a duplicate. Feel free to comment on #4468 if you have feedback on that implementation.

I'm marking this as duplicate and will close once #4468 closes.

We're always looking for help and feel free to tackle one of the labeled good first issue. Please check the issues first to see if there is a PR in progress. Issues under this label that don't have a linked PR are open for contribution.

@dbarker dbarker added duplicate This issue or pull request already exists pr:do-not-merge This PR is not ready to be merged. labels Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

duplicate This issue or pull request already exists pr:do-not-merge This PR is not ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants