feat: support general attribute limits - #4480
Open
NAND-369 wants to merge 1 commit into
Open
Conversation
|
|
Member
|
Hi @NAND-369, Thanks for the contribution! There is already a PR (#4468) open to address #4467 and this PR is a duplicate. Feel free to comment on #4468 if you have feedback on that implementation. I'm marking this as duplicate and will close once #4468 closes. We're always looking for help and feel free to tackle one of the labeled good first issue. Please check the issues first to see if there is a PR in progress. Issues under this label that don't have a linked PR are open for contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Adds support for configuring general
attribute_limitsand propagating them to tracer and logger providers.Implementation
TracerProviderandLoggerProvider.Tests
Added coverage for:
Verification
git diff --checkpasses