Skip to content

[CONFIGURATION/TEST] SdkBuilder test separation and expansion by provider type #4441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dbarker wants to merge 11 commits into
base: main
Choose a base branch
from
Open

[CONFIGURATION/TEST] SdkBuilder test separation and expansion by provider type #4441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
3dedf6a
break up common test objects into signal specific files
dbarker Aug 16, 2026
ae63f35
update programmatic config test to use the separate signal test files…
dbarker Aug 16, 2026
3a13755
update configured_sdk test to use the separate signal test files
dbarker Aug 16, 2026
b55fd5e
move test cases from sdk_builder_test.cc to signal specific test file…
dbarker Aug 16, 2026
52ffdb9
remove sdk builder use in the yaml metrics test
dbarker Aug 16, 2026
5f69e57
add a propagator builders test
dbarker Aug 16, 2026
dcf87cb
update cmake and bazel build files
dbarker Aug 16, 2026
5fcef5a
remove the common test header which is no longer used and cleanup
dbarker Aug 16, 2026
c53c339
fix spelling
dbarker Aug 16, 2026
359a2c0
cleanup metrics builders test: add missing to fixture name. add miss…
dbarker Aug 17, 2026
70921e0
Merge branch 'main' into config_test_separation_by_signal
dbarker Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 27 additions & 3 deletions sdk/test/configuration/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ cc_test(
cc_test(
name = "sdk_builder_test",
srcs = [
"config_test_common.h",
"sdk_builder_test.cc",
],
tags = [
Expand All @@ -48,7 +47,9 @@ cc_test(
cc_test(
name = "configured_sdk_test",
srcs = [
"config_test_common.h",
"config_test_logs.h",
"config_test_metrics.h",
"config_test_trace.h",
"configured_sdk_test.cc",
],
tags = [
Expand All @@ -69,7 +70,10 @@ cc_test(
cc_test(
name = "programmatic_configuration_test",
srcs = [
"config_test_common.h",
"config_test_logs.h",
"config_test_metrics.h",
"config_test_propagators.h",
"config_test_trace.h",
"programmatic_configuration_test.cc",
],
tags = [
Expand All @@ -90,6 +94,7 @@ cc_test(
cc_test(
name = "trace_builders_test",
srcs = [
"config_test_trace.h",
"trace_builders_test.cc",
],
tags = [
Expand All @@ -107,6 +112,7 @@ cc_test(
cc_test(
name = "logs_builders_test",
srcs = [
"config_test_logs.h",
"logs_builders_test.cc",
],
tags = [
Expand All @@ -124,6 +130,7 @@ cc_test(
cc_test(
name = "metrics_builders_test",
srcs = [
"config_test_metrics.h",
"metrics_builders_test.cc",
],
tags = [
Expand All @@ -134,6 +141,23 @@ cc_test(
"//sdk:headers",
"//sdk/src/configuration:configuration_metrics_builders",
"//sdk/src/metrics",
"//test_common:headers",
"@com_google_googletest//:gtest_main",
],
)

cc_test(
name = "propagator_builders_test",
srcs = [
"propagator_builders_test.cc",
],
tags = [
"config",
"test",
],
deps = [
"//sdk:headers",
"//sdk/src/configuration:configuration_core",
"@com_google_googletest//:gtest_main",
],
)
Expand Down
12 changes: 11 additions & 1 deletion sdk/test/configuration/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,22 @@ target_link_libraries(
metrics_builders_test
PRIVATE ${GTEST_BOTH_LIBRARIES} ${CMAKE_THREAD_LIBS_INIT}
opentelemetry_configuration_metrics_builders
opentelemetry_configuration_core)
opentelemetry_configuration_core opentelemetry_test_common)
gtest_add_tests(
TARGET metrics_builders_test
TEST_PREFIX config.
TEST_LIST metrics_builders_test)

add_executable(propagator_builders_test propagator_builders_test.cc)
target_link_libraries(
propagator_builders_test
PRIVATE ${GTEST_BOTH_LIBRARIES} ${CMAKE_THREAD_LIBS_INIT}
opentelemetry_configuration_core)
gtest_add_tests(
TARGET propagator_builders_test
TEST_PREFIX config.
TEST_LIST propagator_builders_test)

foreach(testname sdk_builder_test configured_sdk_test
programmatic_configuration_test)
add_executable(${testname} "${testname}.cc")
Expand Down
Loading
Loading