[BUG] Check what curl_slist_append and curl_multi_init return - #4406

Draft

thc1006 wants to merge 38 commits into

open-telemetry:mainfrom

thc1006:bugfix/check-curl-allocation-failures-4404

Commits on Sep 8, 2026

[BUG] Check what curl_slist_append and curl_multi_init return
thc1006
committed
adf0e8d
[TEST] Make the allocation failure case independent of the libcurl in use
thc1006
committed
7808052
[TEST] Hold what a client without a multi handle does with a request
thc1006
committed
84e3778
[TEST] Cover the synchronous refusal and the instrumented constructor
thc1006
committed
efe9656
[BUG] Stop the IO thread spinning when the multi handle cannot be created
thc1006
committed
46b07be
[TEST] Take the include set include-what-you-use asks for
thc1006
committed
07b1112
[BUG] Stop the IO thread spinning while it has no multi handle
thc1006
committed
31c2cc5
[BUG] Create the multi handle after curl_global_init has run
thc1006
committed
79a105b
[TEST] Describe what the case holds rather than what it used to find
thc1006
committed
4ace159
[BUG] Wait in slices, and keep the null handle out of curl_multi_info_read
thc1006
committed
8cbf5ee
[BUG] Keep the phases that need a multi handle from running without one
thc1006
committed
51c28fc
[BUG] Report the missing handle wait as a wait
thc1006
committed
053a9e8
[CHORE] Say each invariant once in the comments
thc1006
committed
1cae7c9
[TEST] Hold the phase gate with a request queued during the outage
thc1006
committed
3cde484
[BUG] Refuse a request whose easy handle was never created
thc1006
committed
a82ac15
[BUG] Do not retire the IO thread while a queue still holds work
thc1006
committed
6cab0c3
Revert "[BUG] Do not retire the IO thread while a queue still holds work"
thc1006
committed
fe328e2
[BUG] Describe a failed easy handle once, and ask the case for once
thc1006
committed
e8a8870
[BUG] Keep the IO thread while it still owes somebody an answer
thc1006
committed
8336e5f
[BUG] Do not call a multi function without a multi handle
thc1006
committed
0cff9e0
[TEST] Build the client without a multi handle rather than taking one away
thc1006
committed
c699dbc
[BUG] Release what is still queued when the client goes
thc1006
committed
5de469b
[BUG] Take out of the retry queue what is not going to be retried
thc1006
committed
5130da5
[TEST] Do not let a case leave global state behind it
thc1006
committed
7ec7544
[TEST] Fail the second list node, not just the first
thc1006
committed
c27301a
Say in the changelog what else this fixes
thc1006
committed
8040f39
[TEST] Destroy the client with a retry still pending, and nobody cancelling
thc1006
committed
18f8b04
[TEST] Watch the retry from outside the client, not from inside its queue
thc1006
committed
c38fab3
[CHORE] Say what the code does, and let the cases outlive what talks to them
thc1006
committed
4b08772
Take the include include-what-you-use asks for
thc1006
committed
4e61653
Take the other include include-what-you-use asks for
thc1006
committed
9bc7205
[TEST] Refuse a header append by name, not by allocation size
thc1006
committed
9970df5
[BUG] Ask one question about a retry entry, from both places that ask it
thc1006
committed
75bbd42
[BUG] Do not retire on a queue that filled up while this thread was draining it
thc1006
committed
c22a95e
[BUG] Report a failed multi cleanup after the mutex, not under it
thc1006
committed
a91abbe
[TEST] Cover the TLS version range and cipher list that Setup() applies
thc1006
committed
4a4ca9e
[TEST] Name every constructor argument in the new cases
thc1006
committed
3cb26b3
[BUGFIX] Declare the global initializer before the multi handle
thc1006
committed
a17ed8c