Skip to content

[CODE HEALTH] Fix gcc warnings in release maintainer build#3984

Merged
dbarker merged 5 commits intoopen-telemetry:mainfrom
dbarker:ci_run_gcc_release_maintainer_build
Apr 13, 2026
Merged

[CODE HEALTH] Fix gcc warnings in release maintainer build#3984
dbarker merged 5 commits intoopen-telemetry:mainfrom
dbarker:ci_run_gcc_release_maintainer_build

Conversation

@dbarker
Copy link
Copy Markdown
Member

@dbarker dbarker commented Apr 10, 2026

Fixes #3983

Changes

  • Fix warn_unused_result in otlp_file_client.cc
  • Fix maybe-uninitialized in circular_buffer.cc
  • Update CI to run the gcc maintainer tests in both release and debug

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@dbarker dbarker changed the title Ci run gcc release maintainer build [CODE HEALTH] Fix gcc warnings in release maintainer build Apr 10, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.18%. Comparing base (34b4bae) to head (33a80af).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3984   +/-   ##
=======================================
  Coverage   90.18%   90.18%           
=======================================
  Files         230      230           
  Lines        7299     7299           
=======================================
  Hits         6582     6582           
  Misses        717      717           
Files with missing lines Coverage Δ
sdk/src/metrics/data/circular_buffer.cc 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dbarker dbarker marked this pull request as ready for review April 10, 2026 20:43
@dbarker dbarker requested a review from a team as a code owner April 10, 2026 20:43
Copy link
Copy Markdown
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, see minor comment.

@dbarker dbarker merged commit cd4a4cb into open-telemetry:main Apr 13, 2026
68 checks passed
@dbarker dbarker deleted the ci_run_gcc_release_maintainer_build branch April 13, 2026 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CODE HEALTH] GCC reports warnings in maintainer Release builds

3 participants