Allow custom timeseries generation based on eesyplan methods - #511
Draft
paulapreuss wants to merge 9 commits into
Draft
Allow custom timeseries generation based on eesyplan methods#511paulapreuss wants to merge 9 commits into
paulapreuss wants to merge 9 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes changes to the timeseries model (both by deleting the
timeseries_oldfield and addinggeneration_parametersanddescriptionto store metadata - this was cherry-picked from #446). Therefore,python manage.py migrateneeds to be run (also need to be careful when merging).Add the option to generate timeseries based on parameters instead of from a file upload. Currently, this is possible for heat demand and partly possible for PV timeseries (have to figure out how we want to handle weather data).
As described in this issue, the current implementation opens a submodal on the timeseries input that allows the user to input the needed parameters. Based on these parameters, a timeseries is then computed by passing the parameters to the eesyplan method (this is not yet fully implemented).
The way this works is by mapping which assets have a custom timeseries creatioin method in
eesyplanand showing the extra modal for these assets, similar to the COP calculation method. The methods have analogous forms with the same parameters. The idea is to simply pass the cleaned form data as parameters to the timeseries methods.A lot of lines changed are simply because of ruff formatting - I think my pre-commit linter is being more strict than the repository actually asks for. Might drop the commits for readability or keep to clean up a bit while we are at it.