fix(UI): Added tooltip for the breadcrumb rendering in the hash list component - #31965
fix(UI): Added tooltip for the breadcrumb rendering in the hash list component#31965Rohit0301 wants to merge 1 commit into
Conversation
❌ PR checklist incompleteThis PR cannot be merged until the following are addressed on its linked issue:
The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically. Maintainers can bypass this check by adding the |
Code Review ✅ ApprovedAdds tooltip support for breadcrumb rendering in the hash list component. No issues found. OptionsDisplay: compact → Showing less information. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source |
❌ UI Checkstyle Failed❌ ESLint + Prettier + Organise Imports (src)One or more source files have linting or formatting issues. ❌ Core Components - I18n SyncCore-components ❌ Tailwind AuditHardcoded Tailwind values found. Use a design-system utility (run ❌ Antd + Less Deprecation GuardA new Affected filesat Function._resolveFilename (node:internal/modules/cjs/loader:1401:15) Fix locally (fast - only checks files changed in this branch): make ui-checkstyle-changed |
|



Describe your changes:
Fixes #
I worked on ... because ...
Type of change:
High-level design:
N/A — small change.
Tests:
Use cases covered
Unit tests
Backend integration tests
Ingestion integration tests
Playwright (UI) tests
Manual testing performed
UI screen recording / screenshots:
Not applicable.
Checklist:
Fixes <issue-number>: <short explanation>Fixes #<issue-number>above.Greptile Summary
The PR adds a breadcrumb tooltip to hashtag suggestions and verifies that its overlay is mounted within the suggestion-menu viewport.
Confidence Score: 4/5
The PR should not merge until the Tooltip popup-container callback returns the required
HTMLElementtype.The new
closest()callback is inferred to returnElement, which is incompatible with Ant Design'sHTMLElementcontract and causes the required TypeScript CI check to fail; the remaining findings are non-blocking repository-convention issues.Files Needing Attention: openmetadata-ui/src/main/resources/ui/src/components/BlockEditor/Extensions/hashtag/HashList.tsx; openmetadata-ui/src/main/resources/ui/src/components/BlockEditor/Extensions/hashtag/HashList.test.tsx
Important Files Changed
Reviews (1): Last reviewed commit: "fix(UI): Added tooltip for the breadcrum..." | Re-trigger Greptile
Context used: