Skip to content

fix(UI): Added tooltip for the breadcrumb rendering in the hash list component - #31965

Open
Rohit0301 wants to merge 1 commit into
1.13from
fix-29693_1
Open

fix(UI): Added tooltip for the breadcrumb rendering in the hash list component#31965
Rohit0301 wants to merge 1 commit into
1.13from
fix-29693_1

Conversation

@Rohit0301

@Rohit0301 Rohit0301 commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Describe your changes:

Fixes #

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

High-level design:

N/A — small change.

Tests:

Use cases covered

Unit tests

Backend integration tests

Ingestion integration tests

Playwright (UI) tests

Manual testing performed

UI screen recording / screenshots:

Not applicable.

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • My PR is linked to a GitHub issue via Fixes #<issue-number> above.
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.
  • For UI changes: I attached a screen recording and/or screenshots above.
  • I have added tests (unit / integration / Playwright as applicable) and listed them above.

Greptile Summary

The PR adds a breadcrumb tooltip to hashtag suggestions and verifies that its overlay is mounted within the suggestion-menu viewport.

  • Wraps breadcrumb text in a Tooltip with a custom popup container.
  • Adds a hover-based unit test for tooltip placement.

Confidence Score: 4/5

The PR should not merge until the Tooltip popup-container callback returns the required HTMLElement type.

The new closest() callback is inferred to return Element, which is incompatible with Ant Design's HTMLElement contract and causes the required TypeScript CI check to fail; the remaining findings are non-blocking repository-convention issues.

Files Needing Attention: openmetadata-ui/src/main/resources/ui/src/components/BlockEditor/Extensions/hashtag/HashList.tsx; openmetadata-ui/src/main/resources/ui/src/components/BlockEditor/Extensions/hashtag/HashList.test.tsx

Important Files Changed

Filename Overview
openmetadata-ui/src/main/resources/ui/src/components/BlockEditor/Extensions/hashtag/HashList.tsx Adds the breadcrumb tooltip, but its popup-container callback has an incompatible return type and the implementation bypasses repository UI conventions.
openmetadata-ui/src/main/resources/ui/src/components/BlockEditor/Extensions/hashtag/HashList.test.tsx Adds coverage for tooltip placement, with non-blocking raw-string convention violations.

Reviews (1): Last reviewed commit: "fix(UI): Added tooltip for the breadcrum..." | Re-trigger Greptile

Greptile also left 3 inline comments on this PR.

Context used:

  • Context used - CLAUDE.md (source)

@Rohit0301 Rohit0301 self-assigned this Aug 24, 2026
@Rohit0301
Rohit0301 requested a review from a team as a code owner August 24, 2026 12:20
@Rohit0301 Rohit0301 added the safe to test Add this label to run secure Github workflows on PRs label Aug 24, 2026
@github-actions

Copy link
Copy Markdown
Contributor

❌ PR checklist incomplete

This PR cannot be merged until the following are addressed on its linked issue:

  • No GitHub issue is linked. Link an issue in the Development section of the PR (or add Fixes #12345 to the description). For a same-org cross-repo issue, add Fixes open-metadata/<repo>#123 to the description.

The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically.

Maintainers can bypass this check by adding the skip-pr-checks label.

@github-actions github-actions Bot added the UI UI specific issues label Aug 24, 2026
@gitar-bot

gitar-bot Bot commented Aug 24, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Adds tooltip support for breadcrumb rendering in the hash list component. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source

@github-actions

Copy link
Copy Markdown
Contributor

❌ UI Checkstyle Failed

❌ ESLint + Prettier + Organise Imports (src)

One or more source files have linting or formatting issues.

❌ Core Components - I18n Sync

Core-components t() keys, locale files, or language-set are out of sync. Run yarn check-i18n-all locally.

❌ Tailwind Audit

Hardcoded Tailwind values found. Use a design-system utility (run yarn tw-audit:report for the token each value maps to).

❌ Antd + Less Deprecation Guard

A new antd import or new .less file was added. Use UntitledUI + Tailwind for new work.

Affected files

at Function._resolveFilename (node:internal/modules/cjs/loader:1401:15)
at defaultResolveImpl (node:internal/modules/cjs/loader:1057:19)
at resolveForCJSWithHooks (node:internal/modules/cjs/loader:1062:22)
at Function._load (node:internal/modules/cjs/loader:1211:37)
at TracingChannel.traceSync (node:diagnostics_channel:322:14)
at wrapModuleLoad (node:internal/modules/cjs/loader:235:24)
at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:171:5)
at node:internal/main/run_main_module:36:49 {


Fix locally (fast - only checks files changed in this branch):

make ui-checkstyle-changed

@github-actions

Copy link
Copy Markdown
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 63%
63.49% (61171/96346) 44.79% (33574/74942) 46.73% (10240/21911)

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant