open-metadata · ShaileshParmar11 · Aug 25, 2026 · Aug 24, 2026
@@ -176,7 +176,10 @@ export default [
       // TypeScript rules
       '@typescript-eslint/explicit-function-return-type': 'off',
       '@typescript-eslint/explicit-module-boundary-types': 'off',
-      '@typescript-eslint/no-use-before-define': 'warn',
+      // Cleared to zero and locked by the ESLint-cleanup stack — safe reorders
+      // where possible, documented disables for mutual-recursion / derived-below
+      // cases. Promoted to error so CI blocks any regression.
+      '@typescript-eslint/no-use-before-define': 'error',
       'no-unused-expressions': 'off',
       '@typescript-eslint/no-unused-expressions': [
         'error',

@@ -36,7 +36,7 @@
 import { TestDefinition } from '../../../../generated/tests/testDefinition';
 import { TestSuite } from '../../../../generated/tests/testSuite';
 import { TableSearchSource } from '../../../../interface/search.interface';
 import testCaseClassBase from '../../../../pages/IncidentManager/IncidentManagerDetailPage/TestCaseClassBase';
 import {
  addIngestionPipeline,
  deployIngestionPipelineById,
@@ -90,7 +90,7 @@
  testCase,
  showOnlyParameter = false,
  onUpdate,
 }: TestCaseFormDrawerProps) => {
  const { t } = useTranslation();
  const { getResourceLimit } = useLimitStore();
  const { isAirflowAvailable } = useAirflowStatus();
@@ -187,7 +187,7 @@

      const ingestion = await addIngestionPipeline(pipeline);
      if (isAirflowAvailable && ingestionPipeline.EditAll) {
        await deployIngestionPipelineById(ingestion.id ?? '');
      }
    },
    [formContext, testSuite, table, isAirflowAvailable, ingestionPipeline]
@@ -238,7 +238,7 @@
        jsonPatch
      );
      showSuccessToast(
        t('server.update-entity-success', { entity: t('label.test-case') })
      );
      onUpdate?.(updated);
    },
@@ -369,6 +369,8 @@
     testCaseFormBody
   );
 
+  const closeDrawerRef = useRef<() => void>(() => undefined);
+
   const formBody = (
     <HookForm
       form={form}
@@ -387,8 +389,6 @@
     </HookForm>
   );
 
-  const closeDrawerRef = useRef<() => void>(() => undefined);
-
   // Every dismissal path (cancel, X, Escape, backdrop, programmatic close)
   // funnels through the base drawer's onClose, so the parent is notified
   // exactly once and the form resets. The backdrop stays dismissable to match

@@ -115,7 +115,7 @@
 } from '../../../utils/StringUtils';
 import { showErrorToast } from '../../../utils/ToastUtils';
 import { withActivityFeed } from '../../AppRouter/withActivityFeed';
 import { useFormDrawerWithHook } from '../../common/atoms/drawer';
 import { CoverImage } from '../../common/CoverImage/CoverImage.component';
 import DeleteModal from '../../common/DeleteModal/DeleteModal';
 import AnnouncementCard from '../../common/EntityPageInfos/AnnouncementCard/AnnouncementCard';
@@ -153,7 +153,7 @@
  onNavigate,
  refreshDomains,
  isTreeView = false,
 }: DomainDetailsProps) => {
  const { t } = useTranslation();
  const { isMarketplace } = useMarketplaceStore();
  const location = useLocation();
@@ -260,7 +260,7 @@
        setAssetCount(0);
        showErrorToast(
          error as AxiosError,
          t('server.entity-fetch-error', {
            entity: t('label.asset-plural-lowercase'),
          })
        );
@@ -319,13 +319,14 @@
        );
      }
    }
  }, [isVersionsView, encodedFqn]);

  const handleTabChange = (activeKey: string) => {
    if (activeKey === EntityTabs.ASSETS) {
       // refresh domain count when assets tab is selected
       fetchDomainAssets();
     }
+    // eslint-disable-next-line @typescript-eslint/no-use-before-define -- derived below from `tabs`
     if (activeKey !== activeTab) {
       if (onActiveTabChange) {
         onActiveTabChange(activeKey as EntityTabs);
@@ -765,6 +766,7 @@
         const newFqn = domain.parent
           ? `${domain.parent.fullyQualifiedName}.${newName.trim()}`
           : newName.trim();
+        // eslint-disable-next-line @typescript-eslint/no-use-before-define -- derived below from `tabs`
         navigate(getDomainDetailsPath(newFqn, activeTab));
       }
     } catch {
@@ -908,6 +910,7 @@
       handleAssetSave: () => {
         fetchDomainAssets();
         assetTabRef.current?.refreshAssets();
+        // eslint-disable-next-line @typescript-eslint/no-use-before-define -- derived below from `tabs`
         activeTab !== EntityTabs.ASSETS && handleTabChange(EntityTabs.ASSETS);
       },
       setShowAddSubDomainModal: openSubDomainDrawer,

@@ -197,6 +197,7 @@ const DomainTreeView = ({
       const firstDomain = selectDomain(domains, resetExpandedItems, domainFqn);
 
       if ((firstDomain?.childrenCount || 0) > 0 && shouldLoadChildren) {
+        // eslint-disable-next-line @typescript-eslint/no-use-before-define -- useCallback defined below
         loadDomains(firstDomain.fullyQualifiedName as string);
       }
     },

@@ -336,6 +336,7 @@ const AuditLogsPage = () => {
       }
 
       if (!cancelled) {
+        // eslint-disable-next-line @typescript-eslint/no-use-before-define -- mutually recursive with pollOnce
         scheduleNextPoll();
       }
     };

@@ -79,6 +79,36 @@ const VECTOR_INDEXABLE_ENTITIES = new Set([
   'topic',
 ]);
 
+/**
+ * Format avg stage latency as a short human string. Returns "—" when no records or no time
+ * has been recorded yet (e.g. fresh job, or stages that haven't reported timing because the
+ * legacy non-distributed path is in use). Below 1 ms shows "<1 ms" rather than rounding to 0.
+ */
+export const formatLatencyAverage = (
+  totalTimeMs?: number,
+  successRecords?: number
+): string => {
+  // No timing recorded yet (legacy non-distributed path) or no records to divide by.
+  // totalTimeMs === 0 with successRecords > 0 is a valid sub-millisecond batch and
+  // falls through to the "<1 ms" branch.
+  if (
+    totalTimeMs === undefined ||
+    successRecords === undefined ||
+    successRecords <= 0
+  ) {
+    return '—';
+  }
+  const avgMs = totalTimeMs / successRecords;
+  if (avgMs < 1) {
+    return '<1 ms';
+  }
+  if (avgMs < 1000) {
+    return `${avgMs.toFixed(1)} ms`;
+  }
+
+  return `${(avgMs / 1000).toFixed(2)} s`;
+};
+
 export const getEntityStatsData = (data: {
   [key: string]: StepStats;
 }): EntityStatsData[] => {
@@ -144,36 +174,6 @@ export const getEntityStatsData = (data: {
   );
 };
 
-/**
- * Format avg stage latency as a short human string. Returns "—" when no records or no time
- * has been recorded yet (e.g. fresh job, or stages that haven't reported timing because the
- * legacy non-distributed path is in use). Below 1 ms shows "<1 ms" rather than rounding to 0.
- */
-export const formatLatencyAverage = (
-  totalTimeMs?: number,
-  successRecords?: number
-): string => {
-  // No timing recorded yet (legacy non-distributed path) or no records to divide by.
-  // totalTimeMs === 0 with successRecords > 0 is a valid sub-millisecond batch and
-  // falls through to the "<1 ms" branch.
-  if (
-    totalTimeMs === undefined ||
-    successRecords === undefined ||
-    successRecords <= 0
-  ) {
-    return '—';
-  }
-  const avgMs = totalTimeMs / successRecords;
-  if (avgMs < 1) {
-    return '<1 ms';
-  }
-  if (avgMs < 1000) {
-    return `${avgMs.toFixed(1)} ms`;
-  }
-
-  return `${(avgMs / 1000).toFixed(2)} s`;
-};
-
 /**
  * Format throughput in records per second derived from the same total-time / success-records
  * pair. Useful as a secondary signal next to avg latency when comparing entities or runs.

@@ -160,6 +160,22 @@ export const getCronDefaultValue = (appName: string) => {
   return initialValue;
 };
 
+export const getDefaultScheduleFromPeriod = (
+  includePeriodOptions: string[]
+) => {
+  if (includePeriodOptions.includes('day')) {
+    return DEFAULT_SCHEDULE_CRON_DAILY;
+  } else if (includePeriodOptions.includes('week')) {
+    return DEFAULT_SCHEDULE_CRON_WEEKLY;
+  } else if (includePeriodOptions.includes('month')) {
+    return DEFAULT_SCHEDULE_CRON_MONTHLY;
+  } else if (includePeriodOptions.includes('hour')) {
+    return DEFAULT_SCHEDULE_CRON_HOURLY;
+  }
+
+  return DEFAULT_SCHEDULE_CRON_DAILY;
+};
+
 export const getDefaultScheduleValue = ({
   defaultSchedule,
   includePeriodOptions,
@@ -182,22 +198,6 @@ export const getDefaultScheduleValue = ({
   return getDefaultScheduleFromPeriod(includePeriodOptions);
 };
 
-export const getDefaultScheduleFromPeriod = (
-  includePeriodOptions: string[]
-) => {
-  if (includePeriodOptions.includes('day')) {
-    return DEFAULT_SCHEDULE_CRON_DAILY;
-  } else if (includePeriodOptions.includes('week')) {
-    return DEFAULT_SCHEDULE_CRON_WEEKLY;
-  } else if (includePeriodOptions.includes('month')) {
-    return DEFAULT_SCHEDULE_CRON_MONTHLY;
-  } else if (includePeriodOptions.includes('hour')) {
-    return DEFAULT_SCHEDULE_CRON_HOURLY;
-  }
-
-  return DEFAULT_SCHEDULE_CRON_DAILY;
-};
-
 export const getUpdatedStateFromFormState = <T>(
   currentState: StateValue,
   formValues: StateValue & WorkflowExtraConfig & T

@@ -87,6 +87,11 @@ const serializeTimeInterval = (
   return isEmptyExtensionValue(interval) ? undefined : interval;
 };
 
+export const hasPopulatedTableRows = (value: unknown) =>
+  isRecord(value) &&
+  Array.isArray(value.rows) &&
+  value.rows.some((row) => isRecord(row) && Object.values(row).some(Boolean));
+
 const serializeTableValue = (raw: unknown): unknown =>
   hasPopulatedTableRows(raw) ? raw : undefined;
 
@@ -217,11 +222,6 @@ export const filterPopulatedTableRows = <T extends Record<string, unknown>>(
   rows: T[]
 ) => rows.filter((row) => Object.values(row).some(Boolean));
 
-export const hasPopulatedTableRows = (value: unknown) =>
-  isRecord(value) &&
-  Array.isArray(value.rows) &&
-  value.rows.some((row) => isRecord(row) && Object.values(row).some(Boolean));
-
 export const getCustomPropertyEntityPathname = (entityType: string) => {
   const entityPathEntries = Object.entries(ENTITY_PATH);
   const entityPath = entityPathEntries.find(([, path]) => path === entityType);

@@ -83,6 +83,17 @@ const WorkflowHistory = withSuspenseFallback(
   )
 );
 
+const GlossaryTermDomainWidget = () => {
+  const { entityRules } = useGenericContext();
+
+  return (
+    <DomainLabelV2
+      showDomainHeading
+      multiple={entityRules?.canAddMultipleDomains ?? true}
+    />
+  );
+};
+
 export const getGlossaryTermWidgetFromKey = (widgetConfig: WidgetConfig) => {
   if (
     widgetConfig.i.startsWith(GlossaryTermDetailPageWidgetKeys.WORKFLOW_HISTORY)
@@ -121,14 +132,3 @@ export const getGlossaryTermWidgetFromKey = (widgetConfig: WidgetConfig) => {
     />
   );
 };
-
-const GlossaryTermDomainWidget = () => {
-  const { entityRules } = useGenericContext();
-
-  return (
-    <DomainLabelV2
-      showDomainHeading
-      multiple={entityRules?.canAddMultipleDomains ?? true}
-    />
-  );
-};
@@ -166,6 +166,7 @@ export const getKeyValues = ({
       }
 
       // Handle special service configurations
+      // eslint-disable-next-line @typescript-eslint/no-use-before-define -- mutually recursive with getKeyValues
       const specialConfig = handleSpecialServiceConfig(
         serviceType,
         key,
@@ -183,6 +184,7 @@ export const getKeyValues = ({
         serviceType === EntityType.DATABASE_SERVICE &&
         key === 'configSource'
       ) {
+        // eslint-disable-next-line @typescript-eslint/no-use-before-define -- mutually recursive with getKeyValues
         const configSource = handleDatabaseConfigSource(
           key,
           value,
-Original file line number
+Diff line change
@@ Expand Up / @@ -336,6 +336,7 @@ const AuditLogsPage = () => { @@
           }
           if (!cancelled) {
+            // eslint-disable-next-line @typescript-eslint/no-use-before-define -- mutually recursive with pollOnce
             scheduleNextPoll();
           }
         };
@@ Expand Down @@