Migrate FailedTestCaseSampleData table to core-ui Table component#27985
Open
shah-harshit wants to merge 3 commits intomainfrom
Open
Migrate FailedTestCaseSampleData table to core-ui Table component#27985shah-harshit wants to merge 3 commits intomainfrom
shah-harshit wants to merge 3 commits intomainfrom
Conversation
…mponent - Replace Ant Design Table with core-ui Table (react-aria-components) - Add border wrapper tw:border tw:border-border-secondary tw:rounded-[10px] - Add 210px min-width on data cells with horizontal scroll - Add 8px padding on header and data cells - Center diff-type column content vertically and horizontally - Move all styles from .less file to tw: classes using theme tokens - Delete failed-test-case-sample-data.less Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
shah-harshit
added
UI
shah-harshit
changed the title
Contributor
Jest test CoverageUI tests summary
|
Contributor
🟡 Playwright Results — all passed (12 flaky)✅ 4016 passed · ❌ 0 failed · 🟡 12 flaky · ⏭️ 86 skipped
🟡 12 flaky test(s) (passed on retry)
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
![gitar-bot[bot]](https://avatars.githubusercontent.com/in/827041?s=60&v=4){kind=small}
Code Review ✅ Approved 1 resolved / 1 findingsMigrates FailedTestCaseSampleData to the core-ui Table component and adopts Tailwind utility classes. Refactor the hardcoded ✅ 1 resolved✅ Quality: Hardcoded border-radius value violates styling guidelines
OptionsDisplay: compact → Showing less information. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
|
anuj-kumary
reviewed
May 8, 2026
Comment on lines
+294
to
+296
| <span | ||
| className={classNames('tw:font-medium', { | ||
| 'tw:text-success-primary': |
Member
There was a problem hiding this comment.
Can we use here Typography ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tablewith core-uiTable(react-aria-components) inFailedTestCaseSampleData.component.tsxtw:overflow-x-auto tw:border tw:border-border-secondary tw:rounded-[10px]with horizontal scroll supportfailed-test-case-sample-data.lesstotw:theme token classes — delete the.lessfile entirelytw:bg-success-primary,tw:bg-error-primary,tw:text-error-primary,tw:text-success-primary,tw:text-gray-500,tw:bg-gray-50,tw:border-r-gray-blue-100failed-sample-data-columnCSS class for e2e test selector compatibilityReference
https://github.com/open-metadata/openmetadata-collate/issues/3837
Test plan
yarn playwright:run --grep FailedTestCaseSampleData🤖 Generated with Claude Code