chore: flatten pom, add licences to jar#1951
Conversation
* use flatten-maven-plugin and maven-resources-plugin * removes test/publish deps and build profiles from published pom * packages license into jar Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request configures the Maven build to flatten the POM deployed to Maven Central and bundle the root LICENSE file into published JARs, as well as marking Lombok and SpotBugs dependencies as optional. A review comment correctly points out that the specified version of maven-resources-plugin (3.5.0) does not exist and will cause build failures, suggesting a downgrade to 3.3.1.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-resources-plugin</artifactId> | ||
| <version>3.5.0</version> |
There was a problem hiding this comment.
The maven-resources-plugin version 3.5.0 does not exist. The latest stable version of this plugin is 3.3.1. Using a non-existent version will cause the Maven build to fail with a PluginResolutionException when attempting to resolve the plugin. Please downgrade the version to 3.3.1.
| <version>3.5.0</version> | |
| <version>3.3.1</version> |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1951 +/- ##
============================================
+ Coverage 92.27% 93.27% +1.00%
- Complexity 653 656 +3
============================================
Files 59 59
Lines 1592 1592
Branches 179 179
============================================
+ Hits 1469 1485 +16
+ Misses 76 62 -14
+ Partials 47 45 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
4 participants
Published pom hygiene improvements, and fix missing licence in jars: