Fix Class Template Argument Deduction warning#107
Merged
Conversation
In `grpc_sync.cpp` , code declares time points like this: ``` std::chrono::time_point now = std::chrono::steady_clock::now(); ``` `std::chrono::time_point` is a template class that requires template arguments (the clock type and the duration type)``` template<class Clock, class Duration = typename Clock::duration> class time_point; ``` In the upstream code, the template arguments are omitted ( `std::chrono::time_point now` ). Under C++17, the compiler uses a feature called CTAD (Class Template Argument Deduction) to automatically deduce the missing template arguments from the right-hand side ( std::chrono::steady_clock::now() ). So it deduces the type to be std::chrono::time_point<std::chrono::steady_clock> . Some more restrictive type-checkers are warning users of such use. This patch fixes that and explicitly defines time_point type Signed-off-by: Marcin Olko <molko@google.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the variable declarations in CheckGracePeriod and WaitForUpdates to use std::chrono::steady_clock::time_point instead of the incomplete std::chrono::time_point, which resolves CTAD warnings. The reviewer suggests using auto for these declarations to improve readability and maintainability while still addressing the warnings.
oxddr
approved these changes
May 20, 2026
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Marcin Olko <molko@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
In
grpc_sync.cpp, code declares time points like this:std::chrono::time_pointis a template class that requires template arguments (the clock type and the duration type)``` template<class Clock, class Duration = typename Clock::duration> class time_point;Under C++17, the compiler uses a feature called CTAD (Class Template Argument Deduction) to automatically deduce the missing template arguments from the right-hand side ( std::chrono::steady_clock::now() ). So it deduces the type to be std::chrono::time_pointstd::chrono::steady_clock . Some more restrictive type-checkers are warning users of such use. This patch fixes that and explicitly defines time_point type