Use SHA-512 algorithm for SHA-512 RSA-PSS signing in CNG backend#1409
Open
kloploid wants to merge 1 commit into
Open
Use SHA-512 algorithm for SHA-512 RSA-PSS signing in CNG backend#1409kloploid wants to merge 1 commit into
kloploid wants to merge 1 commit into
Conversation
The SHA-512 branch of the PSS padding switch in QCNG::sign() set pszAlgId to NCRYPT_SHA256_ALGORITHM with salt length 64, which made CNG sign with MGF1-SHA256 while the advertised XML-DSIG method is sha512-rsa-MGF1. The PKCS#11 backend correctly uses CKG_MGF1_SHA512 for the same case (QPKCS11.cpp). Signed-off-by: kloploid <mark.zelinski890@gmail.com>
metsma
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.