fix: determine credential generation status from the task expiry - #167
Open
Agrendalath wants to merge 2 commits into
Open
fix: determine credential generation status from the task expiry#167Agrendalath wants to merge 2 commits into
Agrendalath wants to merge 2 commits into
Conversation
Celery Beat maintains the `enabled` flag of a periodic task itself - it disables expired tasks and one-off tasks that have already run - so the flag does not reliably reflect the intended configuration. Add a `CredentialConfiguration.is_generation_enabled` property that uses the `expires` field of the periodic task when it is set, and falls back to the `enabled` flag otherwise. The credential eligibility endpoint now reports this value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Celery Beat maintains the
enabledflag of a periodic task itself - it disables expired tasks and one-off tasks that have already run - so the flag does not reliably reflect the intended configuration.This adds a
CredentialConfiguration.is_generation_enabledproperty that uses theexpiresfield of the periodic task when it is set, and falls back to theenabledflag otherwise. The credential eligibility endpoint now reports this value.