Skip to content

adding tcp traceroute capabilities to Feature/tlsmiddleboxprobe - #1799

Open
snourin wants to merge 10 commits into
masterfrom
feature/tlsmiddleboxprobe
Open

adding tcp traceroute capabilities to Feature/tlsmiddleboxprobe#1799
snourin wants to merge 10 commits into
masterfrom
feature/tlsmiddleboxprobe

Conversation

@snourin

@snourin snourin commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

Checklist

  • I have read the contribution guidelines
  • reference issue for this pull request:
  • if you changed anything related to how experiments work and you need to reflect these changes in the ooni/spec repository, please link to the related ooni/spec pull request: (adding icmp data format spec#308)
  • if you changed code inside an experiment, make sure you bump its version number

Description

PR for the tlsmiddlebox probe using TCP traceroute. Timestamps have been added. Will continue cleaning up the code.

@snourin
snourin requested review from DecFox and hellais as code owners July 24, 2026 09:13
@snourin snourin self-assigned this Jul 24, 2026
@snourin snourin mentioned this pull request Jul 24, 2026
4 tasks
@munzzyy

munzzyy commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

tcp_traceroute_probe.go has no build constraint, so it lands in every platform build. On 013d579:

$ GOOS=windows GOARCH=amd64 go build ./internal/experiment/tlsmiddlebox/
tcp_traceroute_probe.go:46:18: undefined: unix.Socket
tcp_traceroute_probe.go:54:57: undefined: unix.IP_RECVERR

$ GOOS=darwin GOARCH=arm64 go build ./internal/experiment/tlsmiddlebox/
tcp_traceroute_probe.go:54:57: undefined: unix.IP_RECVERR
tcp_traceroute_probe.go:70:57: undefined: unix.SO_TIMESTAMPING

Both are clean on master. PR CI misses it because windows.yml and macos.yml only fire on release branches and the nightly cron. The package already splits by platform in syscall_unix.go / syscall_windows.go / syscall_otherwise.go, so probeTCP could follow that shape.

Also lines 149 and 160-161 print the raw quote to stdout mid-measurement. Leftover from debugging?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants