fix(menubar): order tray % metrics by providers_order#92
Merged
prakersh merged 1 commit intoJul 23, 2026
Merged
Conversation
Tray title used selected_quotas click order, so configuring provider list as Codex → Anthropic → Grok still showed 17%·15%·7% (Codex·Grok·Anthropic). Re-sort multi_provider selected_quotas by providers_order during Settings.Normalize so tray title matches the menubar list order. Co-authored-by: Grok 4.5 (high effort) <302482056+a-grok-build-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
macOS menubar tray percentages ignored the configured provider list order and followed
selected_quotasclick order instead.Repro
17%·15%·7%(Codex·Grok·Anthropic)17%·7%·15%(Codex·Anthropic·Grok)Root cause
TrayTitlewalksstatus_display.selected_quotasin storage order. That array is filled when the user toggles quotas and is not kept in sync withproviders_order.Fix
During
Settings.Normalize(), re-sortselected_quotasbyproviders_orderwhen mode ismulti_provider. Every consumer of normalized settings (tray title, preferences API) then matches the menubar list order.Test plan
go test ./internal/menubar -run 'TrayTitleFollows|OrderSelections'onllm-dev/onWatch@main, single commit onlyRelated
User-facing menubar provider ordering settings; companion of tray multi-provider status display (
selected_quotas, max 3).