Support multiple fee receiver accounts - #100
Open
janezpodhostnik wants to merge 2 commits into
Open
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testnet distributes transaction fee deposits across multiple receiver accounts
since the FlowFees concurrent fee collection upgrade (rolled out in tx
be210889dd26a320f530595bd369093e866e26c3941bf7a3d01f861db3eeda81). Rosettaonly recognized deposits to the FlowFees contract account as fees, so deposits
to the child fee accounts were misclassified as ordinary transfers.
Changes
feeAddrwith a set of fee addresses(
Contracts.FeeAddresses()): the FlowFees account plus a new.contracts.fee_receiversconfig list, documented in the README.testnet.json, verified against theon-chain
FlowFees.getFeeReceiverAddresses()getter.validateFeeReceivers) that fetches the on-chainreceiver list via a new
get-fee-receiversscript and exits with a fatalerror if any on-chain receiver is missing from the config, so future
receiver additions fail loudly instead of silently misclassifying fees.
Extra configured addresses are allowed, since they may be needed to
classify fees in historical blocks.
getFeeReceiverAddresses()getter the script uses.Notes
mainnet.jsonis unchanged andbehavior there is identical. Once the upgrade rolls out there, the startup
check will flag the new receivers and
mainnet.jsonjust needs afee_receiversentry.yet merged. Do not merge this PR until it lands and the pin is updated to a
master commit.
Related: onflow/flow-core-contracts#575, onflow/flow-core-contracts#615, onflow/flow-go#8632