Skip to content

Claude/review delete entities z kenw#48

Open
shuaitseng wants to merge 7 commits intomasterfrom
claude/review-delete-entities-ZKenw
Open

Claude/review delete entities z kenw#48
shuaitseng wants to merge 7 commits intomasterfrom
claude/review-delete-entities-ZKenw

Conversation

@shuaitseng
Copy link
Copy Markdown
Contributor

No description provided.

claude added 2 commits April 7, 2026 07:44
Adds app.py (Flask backend with SSE streaming) and templates/index.html
(minimal frontend) so users can delete Onfleet entities interactively
via a browser instead of editing the script directly.

- Dropdown for entity type (workers, tasks, admins, teams, webhooks)
- Textarea for IDs (one per line) with validation for empty input
- Streams per-ID results live as they complete; errors are caught and
  logged without stopping the remaining deletions
- Final summary shows total success/failure counts

https://claude.ai/code/session_01SDM9Xc97MTzbjaUVwHd2Pc
- All fields now show inline red error messages and a red border when
  invalid; errors clear as soon as the user starts correcting the field
- Entity dropdown now has a blank default option so it can be validated
- Custom modal replaces the browser's confirm() dialog with a warning
  message: "you cannot recover anything back", showing the count and
  entity type before the user commits

https://claude.ai/code/session_01SDM9Xc97MTzbjaUVwHd2Pc
Comment thread api-tools/delete-entities/app.py Fixed
Comment thread api-tools/delete-entities/app.py Fixed
Comment thread api-tools/delete-entities/app.py Fixed
claude added 4 commits April 7, 2026 08:19
- requirements.txt lists flask and requests for one-command install
- README updated with full local setup instructions, UI usage guide,
  disclaimer, file overview, and related resources consistent with
  the rest of the repo's style

https://claude.ai/code/session_01SDM9Xc97MTzbjaUVwHd2Pc
Server-side: wrap user-provided entity value in html.escape() before
embedding in the error message string (app.py line 29).

Client-side: replace innerHTML with explicit DOM construction using
textContent for the server error display, so any unescaped content
from the response is never interpreted as HTML.

https://claude.ai/code/session_01SDM9Xc97MTzbjaUVwHd2Pc
Hardcoded debug=True exposed the Werkzeug interactive debugger to
anyone who could reach the server, allowing arbitrary code execution.
Debug is now off unless FLASK_DEBUG=1 is explicitly set in the
environment. README updated with instructions for toggling it and a
warning not to enable it on shared or internet-facing machines.

https://claude.ai/code/session_01SDM9Xc97MTzbjaUVwHd2Pc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants