fix: use timezone-aware UTC in web search example#670
Open
Ghraven wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace
datetime.utcnow()inexamples/web_search_gpt_oss_helper.pywithdatetime.now(timezone.utc).Bug
The example helper builds
Page.fetched_attimestamps withdatetime.utcnow(), which is deprecated in Python 3.12 because it returns a naive datetime. Running the example on Python 3.12+ can emit deprecation warnings.Before/After
Before:
After:
The value is still UTC, but now it is explicitly timezone-aware.
Verification
python -m compileall -q examples/web_search_gpt_oss_helper.pygit diff --checkrg -n 'datetime\.utcnow\(' examples/web_search_gpt_oss_helper.pyreturns no matches