fix: add missing default=None to modelinfo field in ShowResponse#665
Open
Abzaek wants to merge 1 commit into
Open
fix: add missing default=None to modelinfo field in ShowResponse#665Abzaek wants to merge 1 commit into
Abzaek wants to merge 1 commit into
Conversation
modelinfo was declared Optional but Field() had no default, making it a required field. If the server response omits model_info, Pydantic raises ValidationError. This breaks compatibility with older Ollama servers that don't return model_info.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
modelinfowas declaredOptional[Mapping[str, Any]]but theField()call had nodefaultargument:In Pydantic v2,
Optionalalone does not provide a default — the field is required. If an Ollama server response omitsmodel_info(e.g. older server versions), Pydantic raisesValidationError.Every other
Optionalfield inShowResponseexplicitly sets= None.Fix
Add
default=Noneto the Field call.