refactor: drop dead isReady/isTruthy pass-throughs - #4
Merged
Conversation
useEffectWhenReady/useEffectWhenTruthy hand-wired isReady/isTruthy, which were one-line forwards to predicates.ready/predicates.truthy with no behavior of their own. Call the predicates directly and delete the wrapper files. UseEffectWhenPredicates moves from method syntax to property syntax so predicates.ready/truthy can be passed by reference without tripping @typescript-eslint/unbound-method. Also drops the createEffectWhen JSDoc example that showed baking predicates.ready into a factory-created hook — that pattern silently loses per-call-site tuple narrowing, since createEffectWhen fixes its generic type parameter once at creation time.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
useEffectWhenReady/useEffectWhenTruthy hand-wired isReady/isTruthy, which were one-line forwards to predicates.ready/predicates.truthy with no behavior of their own. Call the predicates directly and delete the wrapper files.
UseEffectWhenPredicates moves from method syntax to property syntax so predicates.ready/truthy can be passed by reference without tripping @typescript-eslint/unbound-method.
Also drops the createEffectWhen JSDoc example that showed baking predicates.ready into a factory-created hook — that pattern silently loses per-call-site tuple narrowing, since createEffectWhen fixes its generic type parameter once at creation time.