feat(scenarios): add repeated-boot-notification scenario - #170
Conversation
Resolves the conflict from branching before ocpp-debugkit#161. The previous resolution left three stray '>' markers (index.ts and index.test.ts) and deleted heartbeat-timeout.ts, which reverted ocpp-debugkit#161 and broke typecheck and build. Restores heartbeat-timeout.ts, drops the markers, rebuilds the registry wiring on current main, and moves the scenario count to 21 across all four sites. The scenario file and changeset are unchanged from this branch.
|
The scenario itself is right, and I have fixed up the branch around it. I ran your trace through the engine and it reports What needed repairing was the merge, not your work. This branch was cut before #161
The scenario count had also moved twice while this sat, because #169 landed I restored the deleted file, dropped the markers, rebuilt the registry wiring on For next time, the thing that avoids all of this: instead of resolving conflicts by Merging now. That is the sixteenth of sixteen detection rules covered, and it takes |
#169 and #170 landed together, so this folds both forward. Rule coverage is complete: all 16 detection rules now have a scenario exercising them, the invariant #140 wrote into CONTRIBUTING. Verified by iterating the registry rather than by reading, 16 of 16 codes appear in some scenario's expectedFailures. The corpus is at 21, clearing the 20+ scenario exit criterion in the v1.0 milestone. Records the fifth and sixth good-first-issue completions (#108 by YANGCHUNHONG3000, #139 by MayurK-cmd), why #170 needed its branch repaired (cut before #161, its conflict resolution deleted heartbeat-timeout.ts and left stray markers that broke typecheck and build), and the station ID allocation now that 020 and 021 have shipped and 022 is next free.
|
Yeah, I was trying to solve the conflicts. Thank you. I will look for more issues; happy to raise a PR! |
Summary
Adds the repeated-boot-notification scenario to the scenario corpus, covering the REPEATED_BOOT_NOTIFICATION detection rule (the one rule that shipped in #114 without an exercising scenario). The synthetic trace on CS-SYNTHETIC-020 reboots a station three times in three minutes (one BootNotification per minute) followed by a single Heartbeat — all three boots land inside the rule's 5 minute window and read as a clear reboot loop rather than a borderline case.
Related Issue
Closes #139
Changes
Checklist
Notes for Reviewer